Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: rename WorkerThreadMain to PlatformWorkerThread #21982

Closed
wants to merge 1 commit into from
Closed

src: rename WorkerThreadMain to PlatformWorkerThread #21982

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jul 26, 2018

Refs: #21079 (comment)

/cc @nodejs/trace-events @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/356/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 26, 2018
@targos targos added lib / src Issues and PRs related to general changes in the lib or src directory. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. c++ Issues and PRs that require attention from people who are familiar with C++. and removed c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jul 26, 2018
@targos
Copy link
Member Author

targos commented Jul 26, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16015/

@refack
Copy link
Contributor

refack commented Jul 26, 2018

Windows fail is #21425

@targos
Copy link
Member Author

targos commented Jul 29, 2018

Rebuild Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/19529/

@targos
Copy link
Member Author

targos commented Jul 29, 2018

Landed in 7639023

@targos targos closed this Jul 29, 2018
@targos targos deleted the platform-worker-thread branch July 29, 2018 12:23
@targos
Copy link
Member Author

targos commented Jul 29, 2018

Forgot to push... Really landed in afc5636

targos added a commit that referenced this pull request Jul 29, 2018
@targos
src: rename WorkerThreadMain to PlatformWorkerThread
afc5636 
Refs: #21079 (comment)

PR-URL: #21982
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos
Copy link
Member Author

targos commented Jul 31, 2018

Depends on #21079 to land on v10.x-staging

blattersturm pushed a commit to citizenfx/node that referenced this pull request Nov 3, 2018
@targos @blattersturm
src: rename WorkerThreadMain to PlatformWorkerThread
588f957 
Refs: nodejs#21079 (comment)

PR-URL: nodejs#21982
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax addaleax added the v8 platform Issues and PRs related to Node's v8::Platform implementation. label Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@ofrobots ofrobots ofrobots approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. v8 platform Issues and PRs related to Node's v8::Platform implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@targos @nodejs-github-bot @refack @ofrobots @jasnell @addaleax @benjamingr @cjihrig @BridgeAR