Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove custom AsyncHooksTestConfiguration #22008

Closed
wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

Has the same behavior as ParallelTestConfiguration, so switch to using that :)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Has the same behavior as `ParallelTestConfiguration`
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Jul 28, 2018
@maclover7
Copy link
Contributor Author

@Trott
Copy link
Member

Trott commented Jul 29, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16053/ (edit @maclover7: ✔️)

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 29, 2018
@maclover7
Copy link
Contributor Author

Landed in 3a056c0

@maclover7 maclover7 closed this Jul 31, 2018
@maclover7 maclover7 deleted the jm-simplify-test branch July 31, 2018 03:51
maclover7 added a commit that referenced this pull request Jul 31, 2018
Has the same behavior as `ParallelTestConfiguration`

PR-URL: #22008
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Jul 31, 2018
Has the same behavior as `ParallelTestConfiguration`

PR-URL: #22008
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants