Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: throw error if port does not exist in options #22085

Closed
wants to merge 7 commits into from
Closed

net: throw error if port does not exist in options #22085

wants to merge 7 commits into from

Commits on Aug 22, 2018

  1. net: throw error if port does not exist in options 

    Throw error ERR_PROPERTY_NOT_IN_OBJECT if the port property does not
exist in the options object argument when calling server.listen().

Refs: nodejs#16712
    @yanivfriedensohn @Trott
    yanivfriedensohn authored and Trott committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    6a90ec5 View commit details
    Browse the repository at this point in the history

  2. errors: add an additional error message argument to ERR_INVALID_OPT_V… 

    …ALUE
    @yanivfriedensohn @Trott
    yanivfriedensohn authored and Trott committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    0c0fbe4 View commit details
    Browse the repository at this point in the history

  3. net: use ERR_INVALID_OPT_VALUE instead of ERR_PROPERTY_NOT_IN_OBJECT

    @yanivfriedensohn @Trott
    yanivfriedensohn authored and Trott committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    54fc80f View commit details
    Browse the repository at this point in the history

  4. errors: remove ERR_PROPERTY_NOT_IN_OBJECT

    @yanivfriedensohn @Trott
    yanivfriedensohn authored and Trott committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    daae72b View commit details
    Browse the repository at this point in the history

  5. test: add tests for the additional error message

    @yanivfriedensohn @Trott
    yanivfriedensohn authored and Trott committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    20b525e View commit details
    Browse the repository at this point in the history

  6. errors: revert adding an additional error message argument to ERR_INV… 

    …ALID_OPT_VALUE
    @yanivfriedensohn @Trott
    yanivfriedensohn authored and Trott committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    7be75d8 View commit details
    Browse the repository at this point in the history

  7. net: use ERR_INVALID_ARG_VALUE instead of ERR_INVALID_OPT_VALUE

    @yanivfriedensohn @Trott
    yanivfriedensohn authored and Trott committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    630d987 View commit details
    Browse the repository at this point in the history