repl: Adding code for handling multiline history #22153

antsmartian · 2018-08-06T16:09:19Z

I always wanted to handle multiline history separately. For example, if I enter a multiline statement and then navigate between the history(s), its very annoying as it shows each line, but I expect it to show the executed line.

~~This is work in progress, but yeah its working and all test cases are passing. I need to handle few~~ ~~more cases and write a unit test case. But thought, what others think over this? May be there is also~~ ~~a better way to do it.~~

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

antsmartian · 2018-08-06T16:39:00Z

Ok looks interesting, test on my mac works perfectly fine. Not sure why CI build is failing though 😕

maclover7 · 2018-08-10T19:30:39Z

cc @nodejs/repl

BridgeAR · 2018-09-05T20:26:21Z

It would be great to get multi line support in the repl. I guess the approach itself is fine for as a first start.

Looping in @jdalton. You seemed to have interest in the repl as well.

antsmartian · 2018-09-06T04:05:16Z

@BridgeAR Thanks for taking a look at it (Yes, I'm interested in repl too 😃 ). Lets wait for @jdalton comments. Ofcourse, this will be in progress as I have to add few more code and as well as test cases for the same.

lib/readline.js

jdalton · 2018-09-26T03:19:40Z

lib/readline.js

@@ -216,6 +217,7 @@ function Interface(input, output, completer, terminal) {

    this.history = [];
    this.historyIndex = -1;
+    console.log('Yes initialized....\n\n\n', this.history);


☝️ is that debug?

My bad, yes did for debugging. Will remove them and update the PR with test cases :)

antsmartian · 2018-09-29T08:13:02Z

@jdalton Have removed the console statement also added the test. Can you please have a look at it?

antsmartian · 2018-10-04T01:18:39Z

@jdalton Can you kindly loop in other folks who also needs to approve this PR before it will get merged? Thanks!

jdalton · 2018-10-04T01:23:21Z

Friendly re-ping of @nodejs/repl 🔊

jasnell · 2018-10-06T04:01:46Z

test/parallel/test-repl-persistent-history.js

+  { // Tests multiline history
+    env: {},
+    test: ['{', '}', UP, CLEAR],
+    expected: [prompt, '{', '... ', '}', '{}\n', prompt, `${prompt}{}`, prompt], // eslint-disable-line max-len


nit: this really shouldn't need the exclusion... just go ahead and wrap.

@jasnell Sure, will take care and push the change. Thanks!

antsmartian · 2018-10-11T14:35:16Z

@jasnell : Addressed your review comments.

antsmartian · 2018-10-14T12:25:12Z

@jasnell / @jdalton Anything needed from my side? Or else can we merge them? Let me know.

jasnell · 2018-10-14T12:31:18Z

There shouldn't be anything else. A lot of us have been tied up this week with a conference. Hopefully this will be landed here soon

lundibundi · 2018-10-26T10:22:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/18169/

lundibundi · 2018-10-26T10:23:46Z

Friendly ping @nodejs/repl if anyone wants to take another look as quite some time has passed.

antsmartian · 2018-11-01T06:36:03Z

@jasnell / @jdalton : Friendly ping 🔔

lib/repl.js

jdalton · 2018-11-02T14:46:22Z

This looks more like a bug fix to me.

PR-URL: nodejs#22153 Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Trott · 2018-11-02T20:57:59Z

Landed in dd7a3d2

antsmartian · 2018-11-03T10:25:45Z

Thanks everyone!

PR-URL: #22153 Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

antsmartian · 2018-11-05T17:25:05Z

@targos I think this can be backported to 10.x. What do you think? I would be happy to raise a PR for the same.

targos · 2018-11-20T09:52:37Z

If this is backported to v10.x, it should be done with #24389

antsmartian · 2018-11-20T10:48:43Z

I guess we are good here, I couldn't see the code in 10.x stage : https://github.com/nodejs/node/blob/v0.10-staging/lib/readline.js

MylesBorins · 2018-11-27T07:30:36Z

This seems like it should perhaps have been Semver-Minor... is that a correct assumption?

nodejs-github-bot added readline Issues and PRs related to the built-in readline module. repl Issues and PRs related to the REPL subsystem. labels Aug 6, 2018

jdalton reviewed Sep 6, 2018

View reviewed changes

lib/readline.js Show resolved Hide resolved

antsmartian force-pushed the multiline-history branch 2 times, most recently from 8093905 to 80084b4 Compare September 9, 2018 04:25

antsmartian force-pushed the multiline-history branch from 80084b4 to 53c5a8b Compare September 26, 2018 02:59

jdalton reviewed Sep 26, 2018

View reviewed changes

antsmartian force-pushed the multiline-history branch from 53c5a8b to 29b5c6e Compare September 29, 2018 07:40

jdalton approved these changes Sep 29, 2018

View reviewed changes

jasnell approved these changes Oct 6, 2018

View reviewed changes

antsmartian force-pushed the multiline-history branch from 29b5c6e to ee6cce4 Compare October 11, 2018 14:34

antsmartian force-pushed the multiline-history branch from ee6cce4 to 097a770 Compare October 14, 2018 04:51

lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 26, 2018

jdalton reviewed Nov 1, 2018

View reviewed changes

lib/repl.js Outdated Show resolved Hide resolved

antsmartian force-pushed the multiline-history branch from 097a770 to f69c51a Compare November 1, 2018 16:07

lib: repl multiline history support

ce91b4d

antsmartian force-pushed the multiline-history branch from f69c51a to ce91b4d Compare November 1, 2018 16:46

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 2, 2018

lib: repl multiline history support

dd7a3d2

PR-URL: nodejs#22153 Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Trott closed this Nov 2, 2018

antsmartian deleted the multiline-history branch November 3, 2018 10:25

antsmartian restored the multiline-history branch November 3, 2018 10:25

antsmartian deleted the multiline-history branch November 3, 2018 10:26

antsmartian restored the multiline-history branch November 3, 2018 10:26

targos pushed a commit that referenced this pull request Nov 3, 2018

lib: repl multiline history support

b3f3ebf

PR-URL: #22153 Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

antsmartian mentioned this pull request Nov 4, 2018

FR: CodeBlocks in REPL. #20817

Closed

vsemozhetbyt mentioned this pull request Nov 7, 2018

repl: handling multiline history needs some case guards #24231

Closed

BridgeAR mentioned this pull request Nov 14, 2018

Release proposal: v11.2 #24350

Merged

This was referenced Nov 15, 2018

2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#232

Closed

2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-android-nodejs#249

Closed

vsemozhetbyt mentioned this pull request Nov 15, 2018

repl: REPL history seems broken in master and v11.2.0 #24385

Closed

antsmartian mentioned this pull request Nov 20, 2018

repl: handle buffered string logic on finish #24389

Closed

4 tasks

MylesBorins added semver-minor PRs that contain new features and should be released in the next minor version. dont-land-on-v8.x labels Nov 27, 2018

BethGriggs added dont-land-on-v10.x and removed lts-watch-v10.x labels Sep 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

repl: Adding code for handling multiline history #22153

repl: Adding code for handling multiline history #22153

antsmartian commented Aug 6, 2018 •

edited

Loading

antsmartian commented Aug 6, 2018

maclover7 commented Aug 10, 2018

BridgeAR commented Sep 5, 2018

antsmartian commented Sep 6, 2018

jdalton Sep 26, 2018

antsmartian Sep 26, 2018

antsmartian commented Sep 29, 2018

antsmartian commented Oct 4, 2018

jdalton commented Oct 4, 2018

jasnell Oct 6, 2018

antsmartian Oct 6, 2018

antsmartian commented Oct 11, 2018 •

edited

Loading

antsmartian commented Oct 14, 2018

jasnell commented Oct 14, 2018

lundibundi commented Oct 26, 2018

lundibundi commented Oct 26, 2018

antsmartian commented Nov 1, 2018

jdalton commented Nov 2, 2018

Trott commented Nov 2, 2018

antsmartian commented Nov 3, 2018

antsmartian commented Nov 5, 2018

targos commented Nov 20, 2018

antsmartian commented Nov 20, 2018

MylesBorins commented Nov 27, 2018

repl: Adding code for handling multiline history #22153

repl: Adding code for handling multiline history #22153

Conversation

antsmartian commented Aug 6, 2018 • edited Loading

Checklist

antsmartian commented Aug 6, 2018

maclover7 commented Aug 10, 2018

BridgeAR commented Sep 5, 2018

antsmartian commented Sep 6, 2018

jdalton Sep 26, 2018

Choose a reason for hiding this comment

antsmartian Sep 26, 2018

Choose a reason for hiding this comment

antsmartian commented Sep 29, 2018

antsmartian commented Oct 4, 2018

jdalton commented Oct 4, 2018

jasnell Oct 6, 2018

Choose a reason for hiding this comment

antsmartian Oct 6, 2018

Choose a reason for hiding this comment

antsmartian commented Oct 11, 2018 • edited Loading

antsmartian commented Oct 14, 2018

jasnell commented Oct 14, 2018

lundibundi commented Oct 26, 2018

lundibundi commented Oct 26, 2018

antsmartian commented Nov 1, 2018

jdalton commented Nov 2, 2018

Trott commented Nov 2, 2018

antsmartian commented Nov 3, 2018

antsmartian commented Nov 5, 2018

targos commented Nov 20, 2018

antsmartian commented Nov 20, 2018

MylesBorins commented Nov 27, 2018

antsmartian commented Aug 6, 2018 •

edited

Loading

antsmartian commented Oct 11, 2018 •

edited

Loading