Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix JS linter #22175

Closed
wants to merge 1 commit into from
Closed

lib: fix JS linter #22175

wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

Not sure why CI (and make -j8 test at the time of landing) showed this
as being OK, but make lint-js is failing now.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@maclover7
lib: fix JS linter
74dcf39 
Not sure why CI (and `make -j8 test` at the time of landing) showed this
as being OK, but `make lint-js` is failing now.
@nodejs-github-bot
Copy link
Collaborator

@maclover7 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/450/pipeline

@nodejs-github-bot nodejs-github-bot added the dgram Issues and PRs related to the dgram subsystem / UDP. label Aug 7, 2018
@maclover7
Copy link
Contributor Author

Collaborators, feel free to 👍 this comment to fast track

(need to step away from the computer for a pre-scheduled thing, but if this gets enough approvals, don't wait for me to land this :))

@maclover7 maclover7 added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 7, 2018
sagirk
sagirk approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@sagirk sagirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@mscdex
Copy link
Contributor

mscdex commented Aug 7, 2018 •
edited
Loading

I think the commit message should be tweaked a bit to describe what is really being changed (dgram, not the linter itself), e.g. 'dgram: fix lint issue' or similar.

@vsemozhetbyt vsemozhetbyt mentioned this pull request Aug 7, 2018
Closed
1 task
@jasnell
Copy link
Member

jasnell commented Aug 7, 2018

Full CI: https://ci.nodejs.org/job/node-test-pull-request/16257/

@jasnell
Copy link
Member

jasnell commented Aug 7, 2018

Redo linuxone CI: https://ci.nodejs.org/job/node-test-commit-linuxone/3637/

jasnell pushed a commit that referenced this pull request Aug 7, 2018
@maclover7 @jasnell
dgram: fix linting issue
e2ea82b 
Not sure why CI (and `make -j8 test` at the time of landing) showed this
as being OK, but `make lint-js` is failing now.

PR-URL: #22175
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 7, 2018

Landed in e2ea82b

@jasnell jasnell closed this Aug 7, 2018
@maclover7 maclover7 deleted the jm-fix-lint branch August 8, 2018 02:17
@snyk-bot snyk-bot mentioned this pull request Aug 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@tniessen tniessen tniessen approved these changes

@sagirk sagirk sagirk approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.