Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: make fs_event_wrap binding internal #22480

Merged
merged 1 commit into from
Aug 29, 2018
Merged

fs: make fs_event_wrap binding internal #22480

merged 1 commit into from
Aug 29, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 23, 2018

Refs: #22160

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/644/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Aug 23, 2018
@jasnell jasnell mentioned this pull request Aug 23, 2018
Closed
33 tasks
@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 23, 2018
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 27, 2018

This needs to be rebased and a CI run, but first it needs another review from @nodejs/tsc.

@cjihrig
fs: make fs_event_wrap binding internal
6e942e7 
PR-URL: nodejs#22480
Refs: nodejs#22160
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 29, 2018

Green CI: https://ci.nodejs.org/job/node-test-pull-request/16828/

@cjihrig cjihrig merged commit 6e942e7 into nodejs:master Aug 29, 2018
@cjihrig cjihrig deleted the fs-event-wrap branch August 29, 2018 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @nodejs-github-bot @jasnell @addaleax @lpinca @targos