Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: state callback behavior on empty chunk #22493

Closed
wants to merge 1 commit into from
Closed

doc: state callback behavior on empty chunk #22493

wants to merge 1 commit into from

Conversation

RubenVerborgh
Copy link
Contributor

Proposed suggestion for #22066 as requested by @mcollina (#22066 (comment)).

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Aug 23, 2018
@vsemozhetbyt
Copy link
Contributor

@mcollina
Copy link
Member

Actually I was wrong, the callback is always called. I couldn't replicate this behavior in modern Node.js, this was some obscure bug that was there in Node.js 0.10, 0.12 and similar.

@mcollina mcollina closed this Aug 24, 2018
@RubenVerborgh RubenVerborgh deleted the patch-2 branch August 25, 2018 01:44
@RubenVerborgh
Copy link
Contributor Author

@mcollina Then #22066 is a problem after all, since OutgoingMessage#write in the http module does not follow that contract?

@mcollina
Copy link
Member

mcollina commented Aug 25, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants