Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: expose pathToFileURL and fileURLToPath #22506

Closed
wants to merge 18 commits into from
Closed
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions doc/api/url.md
Original file line number Diff line number Diff line change
Expand Up @@ -921,6 +921,59 @@ console.log(url.format(myURL, { fragment: false, unicode: true, auth: false }));
// Prints 'https://你好你好/?abc'
```

### url.pathToFileURL(path)

* `path` {string} The absolute path to convert to a File URL.
* Returns: {URL} The file URL object.

This function ensures the correct encodings of URL control characters in file
paths when converting into File URLs.

For example, the following errors can occur when converting from paths to URLs:

```js
// throws for missing schema (posix)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

posix -> POSIX here and below?

// (in Windows the drive letter is detected as the protocol)
new URL(__filename);

// 'file:///foo' instead of the correct 'file:///foo%231' (posix)
new URL('./foo#1', 'file:///');

// 'file:///nas/foo.txt' instead of the correct 'file:///foo.txt' (posix)
new URL(`file://${'//nas/foo.txt'}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this and the next example, template strings with string interpolation seem confusingly redundant. Maybe interpolate previously defined variables?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quite like having these be scannable as single-line cases, initially I wrote new URL('file://' + '//nas/foo.txt') to indicate the separation, but the linter wouldn't allow that.


// 'file:///some/path%' instead of the correct 'file:///some/path%25' (posix)
new URL(`sfile:${'/some/path%.js'}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sfile: -> file://

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

```

where using `pathToFileURL` we can get the correct results above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`pathToFileURL` -> `url.pathToFileURL()`


### url.fileURLToPath(url)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section needs to go before ### url.format(URL[, options]) ABC-wise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, a shame we can't keep these together though.


* `url` {URL} | {string} The file URL string or URL object to convert to a path.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{URL} | {string} -> {URL | string}

* Returns: {URL} The fully-resolved platform-specific Node.js file path.

This function ensures the correct decodings of percent-encoded characters as
well as ensuring a cross-platform valid absolute path string.

When converting from URL to path, the following common errors can occur:

```js
// '/C:/path/' instead of 'C:\path\' (Windows)
new URL('file:///C:/path/').pathname;

// '/foo.txt' instead of '\\nas\foo.txt' (Windows)
new URL('file://nas/foo.txt').pathname;

// '/%E4%BD%A0%E5%A5%BD.txt' instead of '/你好.txt' (posix)
new URL('file:///你好.txt').pathname;

// '/hello%20world.txt' instead of '/hello world.txt' (posix)
new URL('file:///hello world.txt').pathname;
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add an example that uses the new API instead?


where using `fileURLToPath` we can get the correct results above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`fileURLToPath` -> `url.fileURLToPath()`


## Legacy URL API

### Legacy `urlObject`
Expand Down
Loading