Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: simplify http2 wording and formatting #22541

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 26, 2018

Remove It is important to note that and italics from waitForTrailers
sentences.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Remove `It is important to note that` and italics from `waitForTrailers`
sentences.
@Trott Trott added the doc Issues and PRs related to the documentations. label Aug 26, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Aug 26, 2018
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 27, 2018
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 27, 2018
Trott added a commit to Trott/io.js that referenced this pull request Aug 27, 2018
Remove `It is important to note that` and italics from `waitForTrailers`
sentences.

PR-URL: nodejs#22541
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Aug 27, 2018

Landed in a081b43

@Trott Trott closed this Aug 27, 2018
addaleax pushed a commit that referenced this pull request Aug 27, 2018
Remove `It is important to note that` and italics from `waitForTrailers`
sentences.

PR-URL: #22541
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
Remove `It is important to note that` and italics from `waitForTrailers`
sentences.

PR-URL: #22541
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2018
Remove `It is important to note that` and italics from `waitForTrailers`
sentences.

PR-URL: #22541
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request Oct 3, 2018
Remove `It is important to note that` and italics from `waitForTrailers`
sentences.

PR-URL: nodejs#22541
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
Remove `It is important to note that` and italics from `waitForTrailers`
sentences.

PR-URL: nodejs#22541
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
Remove `It is important to note that` and italics from `waitForTrailers`
sentences.

Backport-PR-URL: #22850
PR-URL: #22541
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
@Trott Trott deleted the important branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants