Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky addons/callback-scope/test-resolve-async #22664

Closed
wants to merge 1 commit into from
Closed

test: fix flaky addons/callback-scope/test-resolve-async #22664

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Sep 2, 2018

Example failure: https://ci.nodejs.org/job/node-test-commit-linux/21264/nodes=fedora-latest-x64/console

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Sep 2, 2018
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/776/pipeline

@addaleax addaleax added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 2, 2018
@addaleax
Copy link
Member Author

addaleax commented Sep 2, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16968/

Feel free to 👍 this comment if you approve of fast-tracking.

@addaleax addaleax mentioned this pull request Sep 2, 2018
Closed
lundibundi
lundibundi approved these changes Sep 2, 2018
View reviewed changes
Copy link
Member

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Whoever lands this please also add
Fixes: https://github.com/nodejs/node/issues/22668.

@addaleax
Copy link
Member Author

addaleax commented Sep 3, 2018 •
edited
Loading

Okay, loosened the test a bit more here.

New CI: https://ci.nodejs.org/job/node-test-pull-request/16987/ (:heavy_check_mark:)

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 5, 2018
refack
refack reviewed Sep 5, 2018
View reviewed changes
test/addons/callback-scope/test-resolve-async.js
let called = false;
testResolveAsync().then(() => { called = true; });

setTimeout(() => { assert(called); }, common.platformTimeout(50));
process.on('beforeExit', () => { assert(called); });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use common.mustCall? It uses essentially the same mechanism

node/test/common/index.js

Lines 428 to 429 in b85baf7

// add the exit listener only once to avoid listener leak warnings
if (mustCallChecks.length === 0) process.on('exit', runCallChecks);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal is to have no MakeCallback() calls coming from Node.js before the check is run, since those would also run the microtask queue. process.on('exit') would be too late for that, process.on('beforeExit') should be okay.

@danbev
Copy link
Contributor

danbev commented Sep 7, 2018

Landed in 4a5886c.

@danbev danbev closed this Sep 7, 2018
danbev pushed a commit that referenced this pull request Sep 7, 2018
@addaleax @danbev
test: fix flaky addons/callback-scope/test-resolve-async
4a5886c 
Fixes: #22668
PR-URL: #22664
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 7, 2018
@addaleax @targos
test: fix flaky addons/callback-scope/test-resolve-async
1ce9416 
Fixes: #22668
PR-URL: #22664
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Sep 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack left review comments

@gdams gdams gdams approved these changes

@lundibundi lundibundi lundibundi approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@addaleax @nodejs-github-bot @danbev @refack @jasnell @lpinca @tniessen @BridgeAR @lundibundi @gdams