config: support default user on IBM i #22669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setuid() can not accept a 'nobody' parameter on IBM i. The default user (QSECOFR) on IBM i has user id 0.
nodejs-github-bot
added
the
npm
gireeshpunathil
approved these changes
Sep 3, 2018
addaleax
requested changes
Sep 3, 2018
There was a problem hiding this comment.
Changes to npm should be made upstream to https://github.com/npm/cli, not here.
|
Close this pull request and move it to npm/cli#65 |
|
@dmabupt - I am not a collaborator on that repo, so cannot do formal review |
|
@gireeshpunathil Do you know who at IBM would be able to test that change and confirm to npm that it is correct? |
|
@sam-github, that would be me, @mgoffmn, or @dmabupt (the submitter is from the IBM development team, sorry for any confusion). We have reviewed and tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setuid() can not accept a 'nobody' parameter on IBM i.
The default user (QSECOFR) on IBM i has user id 0.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes