Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 6.8.275.32 #22682

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 6.8.275.32 #22682

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 4, 2018

Refs: v8/v8@6.8.275.30...6.8.275.32

@nodejs/v8-update

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/787/pipeline

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Sep 4, 2018
@targos
Copy link
Member Author

targos commented Sep 4, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17001/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/1653/

@lin7sh
Copy link

lin7sh commented Sep 4, 2018

Just heard about Chrome 69 stable is out, the v8 version comes with it have Lifeoff baseline compiler for WASM, could you use that version instead?

@richardlau
Copy link
Member

Just heard about Chrome 69 stable is out, the v8 version comes with it have Lifeoff baseline compiler for WASM, could you use that version instead?

That's in progress in a separate PR: #21983

@lin7sh
Copy link

lin7sh commented Sep 5, 2018

@richardlau thanks for the link

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 5, 2018
jasnell
jasnell approved these changes Sep 5, 2018
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber-stamp lgtm

@danbev
Copy link
Contributor

danbev commented Sep 7, 2018

Landed in 3295710.

@danbev danbev closed this Sep 7, 2018
danbev pushed a commit that referenced this pull request Sep 7, 2018
@targos @danbev
deps: patch V8 to 6.8.275.32
3295710 
PR-URL: #22682
Refs: v8/v8@6.8.275.30...6.8.275.32
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Sep 7, 2018
@targos
deps: patch V8 to 6.8.275.32
e85aa19 
PR-URL: #22682
Refs: v8/v8@6.8.275.30...6.8.275.32
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Sep 18, 2018
Merged
@targos targos deleted the v8-patch-32 branch October 17, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @nodejs-github-bot @lin7sh @richardlau @danbev @jasnell @BridgeAR