Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make FIXED_ONE_BYTE_STRING an inline fn #22725

Closed
wants to merge 1 commit into from
Closed

src: make FIXED_ONE_BYTE_STRING an inline fn #22725

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Sep 6, 2018

This prevents accidental usage on non-fixed strings.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
src: make FIXED_ONE_BYTE_STRING an inline fn
9c97e4f 
This prevents accidental usage on non-fixed strings.
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/814/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels Sep 6, 2018
@addaleax addaleax added lib / src Issues and PRs related to general changes in the lib or src directory. and removed node-api Issues and PRs related to the Node-API. labels Sep 6, 2018
jasnell
jasnell approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.... :-)

@danbev
Copy link
Contributor

danbev commented Sep 9, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17088/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 9, 2018
@danbev
Copy link
Contributor

danbev commented Sep 10, 2018

Landed in 932a74a.

@danbev danbev closed this Sep 10, 2018
danbev pushed a commit that referenced this pull request Sep 10, 2018
@addaleax @danbev
src: make FIXED_ONE_BYTE_STRING an inline fn
932a74a 
This prevents accidental usage on non-fixed strings.

PR-URL: #22725
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax deleted the FIXED_ONE_BYTE_STRING branch September 10, 2018 11:38
targos pushed a commit that referenced this pull request Sep 10, 2018
@addaleax @targos
src: make FIXED_ONE_BYTE_STRING an inline fn
0c32428 
This prevents accidental usage on non-fixed strings.

PR-URL: #22725
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Sep 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@JungMinu JungMinu JungMinu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @nodejs-github-bot @danbev @jasnell @cjihrig @JungMinu @devsnek