tools: update dmn to 2.0.0 #22733
Closed
tools: update dmn to 2.0.0 #22733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New version of dmn with better support for case-sensitive file systems. Use it in the update-* scripts.
|
👍 here for fast-tracking. |
|
This code is not exercised in CI, so the lite CI should be sufficient. |
silverwind
approved these changes
Sep 6, 2018
BridgeAR
approved these changes
Sep 6, 2018
richardlau
approved these changes
Sep 6, 2018
cjihrig
approved these changes
Sep 6, 2018
targos
approved these changes
Sep 6, 2018
|
Landed in 7a50dba |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Sep 6, 2018
New version of dmn with better support for case-sensitive file systems. Use it in the update-* scripts. PR-URL: nodejs#22733 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
New version of dmn with better support for case-sensitive file systems. Use it in the update-* scripts. PR-URL: #22733 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of dmn with better support for case-sensitive file systems.
Use it in the update-* scripts.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes