Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove string literal from deepStrictEqual #22742

Closed
wants to merge 1 commit into from
Closed

test: remove string literal from deepStrictEqual #22742

wants to merge 1 commit into from

Conversation

iliashkolyar
Copy link
Contributor

@iliashkolyar iliashkolyar commented Sep 7, 2018 •
edited
Loading

test: remove string literal from deepStrictEqual

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 7, 2018
@Trott
Copy link
Member

Trott commented Sep 7, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17070/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 7, 2018
@Trott
Copy link
Member

Trott commented Sep 7, 2018

Resume build: https://ci.nodejs.org/job/node-test-pull-request/17075/

@danbev
Copy link
Contributor

danbev commented Sep 10, 2018

Landed in 33eb509.

@danbev danbev closed this Sep 10, 2018
danbev pushed a commit that referenced this pull request Sep 10, 2018
@iliashkolyar @danbev
test: remove string literal from deepStrictEqual
33eb509 
PR-URL: #22742
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit that referenced this pull request Sep 10, 2018
@iliashkolyar @targos
test: remove string literal from deepStrictEqual
d5e9801 
PR-URL: #22742
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@iliashkolyar iliashkolyar deleted the gzip_test_assertion_modification branch September 10, 2018 17:37
@targos targos mentioned this pull request Sep 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@iliashkolyar @Trott @danbev @jasnell @lpinca @cjihrig @richardlau @nodejs-github-bot