Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make doc generation work on Windows #22749

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Sep 7, 2018

#21697 broke doc generation on Windows since the option name for the output directory was incorrect.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Sep 7, 2018
@tniessen
Copy link
Member Author

tniessen commented Sep 7, 2018

Please 👍 here to approve fast-tracking.

@refack
Copy link
Contributor

refack commented Sep 7, 2018

/CC @nodejs/platform-windows @nodejs/build-files

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 8, 2018
@tniessen
Copy link
Member Author

tniessen commented Sep 8, 2018

Landed in 3f67190.

@tniessen tniessen closed this Sep 8, 2018
tniessen added a commit to tniessen/node that referenced this pull request Sep 8, 2018
PR-URL: nodejs#22749
Refs: nodejs#21697
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 9, 2018
PR-URL: #22749
Refs: #21697
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants