doc: clarify assigning issues to the TSC #22759
Conversation
|
Hmm... breaks workflows how? I'm not sure I agree with a restriction not to use the GitHub UI for requesting TSC review. |
|
There's no way to filter requests to a specific person or to teams. Please don't use it. |
|
As a non-contributing observer, I agree with @fhinkel |
|
|
|
@fhinkel I use that feature to request reviews from the TSC for semver-major changes or in very rare cases, PRs that are controversial. Would it therefore actually not be good to see that PR in your list? |
|
In my experience, the review label was completely ignored so far. |
|
I just put one PR back on the TSC agenda as well, since not enough members reacted to your request to provide feedback to two competing PRs. |
|
Yes, it's very annoying to get those requests. Instead of making me anything review faster, I don't review anything at all because it's too much spam and end up missing requests targeted directly at me. |
|
But how is something spam that only the TSC |
COLLABORATOR_GUIDE.md
Outdated
|
|
||
| - is labeled `semver-major`, or | ||
| - has a significant impact on the codebase, or | ||
| - is inherently controversial, or | ||
| - has failed to reach consensus amongst the Collaborators who are | ||
| actively participating in the discussion. | ||
|
|
||
| Assign the `tsc-review` label or @-mentioning the |
|
It's spam because it goes to 19 people independent of whether they've already reviewed it. I have a day job. I want to look at TSC issues after hours and not have them in my list. Partially my fault for not using separate accounts. But when using the same account theres no way to separate them. |
|
If you use the label or mention, I can grab for the label or search my inbox for TSC reviews. |
|
And it's not like TSC members respond to the group review request, so you might as well not do it and save me a big headache. |
|
Pinging the right individual people directly usually works better. Either via mention or Twitter/email. There's so much noise on GitHub, it's really hard to stay on top. |
|
Unaware about the internal workflow complexity, but convincing to hear from the person who manages that. In addition, it brings the best use of the label - if an action with same purpose is carried out through multiple means, the rule gets vague. This brings clarity to those. |
|
@fhinkel FWIW this is how I fixed this issue on my side: Edit: you can also keep everything but node with |
COLLABORATOR_GUIDE.md
Outdated
|
|
||
| - is labeled `semver-major`, or | ||
| - has a significant impact on the codebase, or | ||
| - is inherently controversial, or | ||
| - has failed to reach consensus amongst the Collaborators who are | ||
| actively participating in the discussion. | ||
|
|
||
| Assign the `tsc-review` label or @-mention the | ||
| `@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][]. | ||
| Do not use the GitHub UI on the right hand side to assign to` |
There was a problem hiding this comment.
Nit: extra backtick at the line end.
There was a problem hiding this comment.
Rather than making this a hard rule without documenting the reasons for it, consider rewording as a suggestion with the reasons why one might want to avoid it. Also, consider, that the same likely applies to requesting review from any team, not just the @nodejs/tsc.
The following is too wordy given that it's 6:30am on a Saturday and I haven't had enough coffee but this should illustrate the point:
Use of the GitHub UI to assign an issue to, or request a review
from the `@nodejs/tsc` (or any team) is not recommended because,
at the current time, doing so causes unnecessary notifications to
be sent to team members who may already have provided feedback or
reviews for the issue or PR. It is better to selectively request
reviews on an individual basis.
More Friendly-Advice-To-Make-Co-Contributors-Lives-Easier, less Yet-Another-Rule-One-Has-To-Follow.
| Assign the `tsc-review` label or @-mention the | ||
| `@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][]. | ||
| Do not use the GitHub UI on the right hand side to assign to | ||
| `@nodejs/tsc` or request a review from `@nodejs/tsc`. |
There was a problem hiding this comment.
Would it still be fine to use it once in the beginning? That way it would show up for the whole TSC. Just assigning it a second time would be discouraged after the first TSC member looked at it?
There was a problem hiding this comment.
What's the hoped-for result that wouldn't be achieved with an @-mention?
I do think that getting TSC reviews is a bit of a problem right now. I think there are some culture/people changes that need to happen more than process changes to fix that, though.
Trott
added
the
author ready
PR-URL: nodejs#22759 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
|
Landed in af522c1 |
PR-URL: #22759 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
PR-URL: #22759 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Using the right hand side to assign
@nodejs/tscor to request reviews from@nodejs/tscbreaks all kinds of workflows and filter rules. Please use the appropriatetsc-reviewlabel or mention@nodejs/tscin a comment instead.