doc, win: improve os.setPriority documentation #22817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
approved these changes
Sep 12, 2018
addaleax
approved these changes
Sep 12, 2018
addaleax
added
doc
cjihrig
approved these changes
Sep 12, 2018
mscdex
reviewed
Sep 12, 2018
| if (expected < PRIORITY_HIGH) | ||
| assert.strictEqual(priority, PRIORITY_HIGHEST); | ||
| assert.ok(priority === PRIORITY_HIGHEST || priority === PRIORITY_HIGH); |
There was a problem hiding this comment.
Instead of doing this for all cases, can we make an explicit check for Windows and possibly for elevated user status before making this kind of assertion?
There was a problem hiding this comment.
This is for Windows only (see line 114)
There was a problem hiding this comment.
I see, can we check for elevated status then? Perhaps using this method or something similar (without 3rd party utilities)?
cjihrig
pushed a commit
to libuv/libuv
that referenced
this pull request
Sep 18, 2018
Refs: nodejs/node#22817 PR-URL: #1985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
|
Landed in 6e746f1. |
This was referenced Sep 25, 2018
cjihrig
added a commit
to cjihrig/libuv
that referenced
this pull request
Sep 26, 2018
Refs: nodejs/node#22817 Refs: libuv/help#64 PR-URL: libuv#2002 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes the test: #22799
See https://support.microsoft.com/en-us/help/110853/prb-can-t-increase-process-priority
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes