Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add gabrielschulhof to TSC #22818

Closed
wants to merge 1 commit into from
Closed

doc: add gabrielschulhof to TSC #22818

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 12, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott Trott added notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 12, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 12, 2018
@Trott
Copy link
Member Author

Trott commented Sep 12, 2018

@nodejs/tsc Please 👍 here to fast-track.

@nodejs-github-bot
Copy link
Collaborator

@Trott sadly an error occured when I tried to trigger a build :(

mcollina
mcollina approved these changes Sep 12, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented Sep 12, 2018

Was unable to start a lite CI job, so I started a full CI: https://ci.nodejs.org/job/node-test-pull-request/17139/

@Trott
Copy link
Member Author

Trott commented Sep 12, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/865/ Linter looks like it's out of commission at the moment. Job should get a replay when it's fixed.

@Trott
Copy link
Member Author

Trott commented Sep 12, 2018 •
edited
Loading

Looks like @refack fixed the linter and initiated a re-run. 🎉 ❤️

https://ci.nodejs.org/job/node-linter/850

MylesBorins
MylesBorins approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau mentioned this pull request Sep 12, 2018
Merged
Trott added a commit to Trott/io.js that referenced this pull request Sep 13, 2018
@Trott
doc: add gabrielschulhof to TSC
82b752a 
PR-URL: nodejs#22818
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@Trott
Copy link
Member Author

Trott commented Sep 13, 2018

Landed in 82b752a

@Trott Trott closed this Sep 13, 2018
targos pushed a commit that referenced this pull request Sep 14, 2018
@Trott @targos
doc: add gabrielschulhof to TSC
b9fd99e 
PR-URL: #22818
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@targos targos mentioned this pull request Sep 18, 2018
Merged
targos pushed a commit that referenced this pull request Sep 19, 2018
@Trott @targos
doc: add gabrielschulhof to TSC
684705c 
PR-URL: #22818
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos pushed a commit that referenced this pull request Sep 20, 2018
@Trott @targos
doc: add gabrielschulhof to TSC
cf95b61 
PR-URL: #22818
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@Trott Trott deleted the tsc-gabriel branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@addaleax addaleax addaleax approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.