Skip to content

crypto: assign missing deprecation code #22827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

crypto: assign missing deprecation code #22827

wants to merge 1 commit into from

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Sep 12, 2018

I forgot to assign the deprecation code while landing #22747, thanks to @vsemozhetbyt for noticing.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 12, 2018

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/870/pipeline

@nodejs-github-bot nodejs-github-bot added the crypto Issues and PRs related to the crypto subsystem. label Sep 12, 2018
@tniessen
Copy link
Member Author

tniessen commented Sep 12, 2018

Please add 👍 here to approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the deprecations Issues and PRs related to deprecations. label Sep 12, 2018
@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 12, 2018
@tniessen
Copy link
Member Author

tniessen commented Sep 12, 2018

Landed in 360465d.

@tniessen tniessen closed this Sep 12, 2018
tniessen added a commit that referenced this pull request Sep 12, 2018
@tniessen
crypto: assign missing deprecation code
360465d 
PR-URL: #22827
Refs: #22747
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

+1 more reviewer

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

crypto Issues and PRs related to the crypto subsystem. deprecations Issues and PRs related to deprecations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tniessen @nodejs-github-bot @jasnell @vsemozhetbyt @targos