Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix vm enumerator callbacks #22836

Closed
wants to merge 2 commits into from
Closed

src: fix vm enumerator callbacks #22836

wants to merge 2 commits into from

Commits on Sep 18, 2018

  1. src: implement query callbacks for vm 

    This is a re-land of a commit landed as part of
nodejs#22390.

---

This allows using a Proxy object as the sandbox for a VM context.

Refs: nodejs#22390
Fixes: nodejs#17480
Fixes: nodejs#17481
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @TimothyGu @addaleax
    TimothyGu authored and addaleax committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    cdb7d2f View commit details
    Browse the repository at this point in the history

  2. src: fix vm enumerator callbacks 

    Some of the choices here are odd, including that symbols are missing.
However, that matches previous behaviour.

What had to be changed was that inherited properties are no longer
included; the alternative would be to also refactor the descriptor
callbacks to provide data for inherited properties.

Fixes: nodejs#22723
Refs: nodejs#22390
    @addaleax
    addaleax committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    276ad5e View commit details
    Browse the repository at this point in the history