test: remove flaky designation for test #22856

Trott · 2018-09-14T05:12:52Z

Unreliability for test-trace-events-fs-sync is believed to have been
fixed. Remove flaky designation.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot · 2018-09-14T05:13:02Z

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/887/pipeline

Trott · 2018-09-14T05:13:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/17182/

Trott · 2018-09-14T05:13:33Z

@ofrobots

Trott · 2018-09-14T17:18:54Z

Looks like we're now getting SIGABRT rather than SIGSEGV? Is that a step in the right direction? (I think so...)

https://ci.nodejs.org/job/node-test-commit-freebsd/20477/nodes=freebsd11-x64/console

22:24:54 not ok 1905 parallel/test-trace-events-fs-sync
22:24:54   ---
22:24:54   duration_ms: 3.60
22:24:54   severity: fail
22:24:54   exitcode: 1
22:24:54   stack: |-
22:24:54     assert.js:84
22:24:54       throw new AssertionError(obj);
22:24:54       ^
22:24:54     
22:24:54     AssertionError [ERR_ASSERTION]: fs.sync.stat:
22:24:54     { status: null,
22:24:54       signal: 'SIGABRT',
22:24:54       output: [ null, '', '' ],
22:24:54       pid: 99508,
22:24:54       stdout: '',
22:24:54       stderr: '' }
22:24:54         at Object.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/parallel/test-trace-events-fs-sync.js:139:10)
22:24:54         at Module._compile (internal/modules/cjs/loader.js:694:30)
22:24:54         at Object.Module._extensions..js (internal/modules/cjs/loader.js:705:10)
22:24:54         at Module.load (internal/modules/cjs/loader.js:604:32)
22:24:54         at tryModuleLoad (internal/modules/cjs/loader.js:543:12)
22:24:54         at Function.Module._load (internal/modules/cjs/loader.js:535:3)
22:24:54         at Function.Module.runMain (internal/modules/cjs/loader.js:747:12)
22:24:54         at startup (internal/bootstrap/node.js:270:19)
22:24:54         at bootstrapNodeJSCore (internal/bootstrap/node.js:801:3)
22:24:54   ...

Unreliability for test-trace-events-fs-sync is believed to have been fixed. Remove flaky designation. Ref: nodejs#22812 Ref: nodejs#21038 (comment)

Trott · 2018-10-06T13:11:43Z

merge conflict resolved

CI: https://ci.nodejs.org/job/node-test-pull-request/17664/

thefourtheye

Do we need a node-stress-single-test, just to be sure?

refack · 2018-10-06T15:21:25Z

Stress -j 8 parallel/test-t* X 500 X [freebsd11-x64, rhel72-s390x, win2016-1p-vs2017 ]
https://ci.nodejs.org/job/node-stress-single-test/2061/

Trott · 2018-10-06T17:20:50Z

Windows stress test failed while building:

09:26:10 c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\src\heap\code-stats.cc : fatal error C1002: compiler is out of heap space in pass 2 [c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\gypfiles\mksnapshot.vcxproj]
09:26:10 LINK : fatal error LNK1257: code generation failed [c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\gypfiles\mksnapshot.vcxproj]

ofrobots · 2018-10-06T17:26:08Z

That seems like an infra issue - c++ compiler ran out of memory.

…

On Sat, Oct 6, 2018, 10:22 AM Rich Trott ***@***.***> wrote: Windows stress test failed while building: 09:26:10 c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\src\heap\code-stats.cc : fatal error C1002: compiler is out of heap space in pass 2 [c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\gypfiles\mksnapshot.vcxproj]09:26:10 LINK : fatal error LNK1257: code generation failed [c:\workspace\node-stress-single-test\nodes\win2016-1p-vs2017\deps\v8\gypfiles\mksnapshot.vcxproj] — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22856 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAE0qWmfM49QYdSWtKJCdbt6UflaBsRMks5uiObFgaJpZM4WooHB> .

Trott · 2018-10-06T17:45:44Z

Trying Windows again, hoping it compiles this time...: https://ci.nodejs.org/job/node-stress-single-test/2062/

Trott · 2018-10-06T21:25:49Z

Windows stress test compile failed again. 😞

Trott · 2018-10-06T21:28:23Z

Windows stress test rebuild but this time on a few different Windows variants. Hopefully if one or two fail, one or two others will successfully build and we'll see how the tests go. https://ci.nodejs.org/job/node-stress-single-test/2063/

refack · 2018-10-07T00:17:58Z

That's an interesting thing to follow up on form a @nodejs/build perspective.

09:26:10 deps\v8\src\heap\code-stats.cc : fatal error C1002: compiler is out of heap space in pass 2
[deps\v8\gypfiles\mksnapshot.vcxproj]

on https://ci.nodejs.org/computer/test-azure_msft-win2016-x64-6/

refack · 2018-10-07T00:21:21Z

🔨

https://ci.nodejs.org/job/node-stress-single-test/2061/nodes=freebsd11-x64/testReport/junit/(root)/test419/parallel_test_trace_events_category_used/

assert.js:84
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ ''
- 'false\n'
    at ChildProcess.procDisabled.once.common.mustCall (/usr/home/iojs/build/workspace/node-stress-single-test/nodes/freebsd11-x64/test/parallel/test-trace-events-category-used.js:52:10)

1 in 500 on freebsd11

not ok 178 parallel/test-tls-zero-clear-in
  ---
  duration_ms: 1.209
  severity: fail
  exitcode: 1
  stack: |-
    events.js:167
          throw er; // Unhandled 'error' event
          ^
    
    Error: read ECONNRESET
        at TLSWrap.onStreamRead (internal/stream_base_commons.js:111:27)
    Emitted 'error' event at:
        at emitErrorNT (internal/streams/destroy.js:82:8)
        at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
        at process._tickCallback (internal/process/next_tick.js:63:19)
  ...

On https://ci.nodejs.org/job/node-stress-single-test/2063/nodes=win10-vs2017/

refack

IMHO stress passed.

Unreliability for test-trace-events-fs-sync is believed to have been fixed. Remove flaky designation. Ref: nodejs#22812 Ref: nodejs#21038 (comment) PR-URL: nodejs#22856 Refs: nodejs#22812 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Refael Ackermann <refack@gmail.com>

Trott · 2018-10-07T03:53:37Z

Landed in e5170d4

Unreliability for test-trace-events-fs-sync is believed to have been fixed. Remove flaky designation. Ref: #22812 Ref: #21038 (comment) PR-URL: #22856 Refs: #22812 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Refael Ackermann <refack@gmail.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 14, 2018

richardlau approved these changes Sep 14, 2018

View reviewed changes

gireeshpunathil approved these changes Sep 14, 2018

View reviewed changes

starkwang approved these changes Sep 14, 2018

View reviewed changes

cjihrig approved these changes Sep 14, 2018

View reviewed changes

jasnell approved these changes Sep 19, 2018

View reviewed changes

test: remove flaky designation for test

0b924f4

Unreliability for test-trace-events-fs-sync is believed to have been fixed. Remove flaky designation. Ref: nodejs#22812 Ref: nodejs#21038 (comment)

Trott force-pushed the flaky-no-more branch from 90bfe69 to 0b924f4 Compare October 6, 2018 13:11

thefourtheye approved these changes Oct 6, 2018

View reviewed changes

hiroppy approved these changes Oct 6, 2018

View reviewed changes

refack approved these changes Oct 7, 2018

View reviewed changes

refack added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 7, 2018

Trott closed this Oct 7, 2018

targos mentioned this pull request Oct 7, 2018

Release proposal: v10.12.0 #23313

Merged

Trott deleted the flaky-no-more branch January 13, 2022 22:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: remove flaky designation for test #22856

test: remove flaky designation for test #22856

Trott commented Sep 14, 2018

nodejs-github-bot commented Sep 14, 2018

Trott commented Sep 14, 2018

Trott commented Sep 14, 2018

Trott commented Sep 14, 2018

Trott commented Oct 6, 2018

thefourtheye left a comment

refack commented Oct 6, 2018

Trott commented Oct 6, 2018

ofrobots commented Oct 6, 2018 via email

Trott commented Oct 6, 2018

Trott commented Oct 6, 2018

Trott commented Oct 6, 2018

refack commented Oct 7, 2018

refack commented Oct 7, 2018 •

edited

Loading

refack left a comment

Trott commented Oct 7, 2018

test: remove flaky designation for test #22856

test: remove flaky designation for test #22856

Conversation

Trott commented Sep 14, 2018

Checklist

nodejs-github-bot commented Sep 14, 2018

Trott commented Sep 14, 2018

Trott commented Sep 14, 2018

Trott commented Sep 14, 2018

Trott commented Oct 6, 2018

thefourtheye left a comment

Choose a reason for hiding this comment

refack commented Oct 6, 2018

Trott commented Oct 6, 2018

ofrobots commented Oct 6, 2018 via email

Trott commented Oct 6, 2018

Trott commented Oct 6, 2018

Trott commented Oct 6, 2018

refack commented Oct 7, 2018

refack commented Oct 7, 2018 • edited Loading

refack left a comment

Choose a reason for hiding this comment

Trott commented Oct 7, 2018

refack commented Oct 7, 2018 •

edited

Loading