Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: check if stream is not destroyed before sending trailers #22896

Closed
wants to merge 1 commit into from
Closed

http2: check if stream is not destroyed before sending trailers #22896

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

Fixes #22855.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/904/pipeline

@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Sep 17, 2018
@mcollina mcollina mentioned this pull request Sep 17, 2018
Closed
@mcollina
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17230/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 17, 2018
@mcollina
Copy link
Member Author

Landed in c9d4304

@mcollina mcollina closed this Sep 19, 2018
@mcollina mcollina deleted the fix-22855 branch September 19, 2018 15:35
mcollina added a commit that referenced this pull request Sep 19, 2018
@mcollina
http2: check if stream is not destroyed before sending trailers
c9d4304 
Fixes: #22855
PR-URL: #22896
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@sogaani sogaani mentioned this pull request Sep 20, 2018
Open
5 tasks
targos pushed a commit that referenced this pull request Sep 20, 2018
@mcollina @targos
http2: check if stream is not destroyed before sending trailers
89fe9ed 
Fixes: #22855
PR-URL: #22896
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request Oct 3, 2018
@mcollina @kjin
http2: check if stream is not destroyed before sending trailers
57ac6a5 
Fixes: nodejs#22855
PR-URL: nodejs#22896
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 11, 2018
Closed
Closed
Closed
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@mcollina @kjin
http2: check if stream is not destroyed before sending trailers
2fd285a 
Fixes: nodejs#22855
PR-URL: nodejs#22896
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@mcollina @BethGriggs
http2: check if stream is not destroyed before sending trailers
9f79341 
Fixes: #22855
Backport-PR-URL: #22850
PR-URL: #22896
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski Awaiting requested review from apapirovski

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcollina @nodejs-github-bot @jasnell @cjihrig @BridgeAR