Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove unused parameter #22902

Closed
wants to merge 1 commit into from
Closed

lib: remove unused parameter #22902

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

The parameter is neither used within the function nor passed from other functions.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/907/pipeline

@nodejs-github-bot nodejs-github-bot added the crypto Issues and PRs related to the crypto subsystem. label Sep 17, 2018
@tniessen
Copy link
Member Author

Please add 👍 here to approve fast-tracking.

@tniessen
Copy link
Member Author

tniessen commented Sep 17, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/17235/
Resumed in https://ci.nodejs.org/job/node-test-pull-request/17246/
Resumed in https://ci.nodejs.org/job/node-test-pull-request/17265/

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 17, 2018
Trott
Trott approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@Trott
Copy link
Member

Trott commented Sep 18, 2018

Only red in the CI is arm-fanned. Here's a rebuild: https://ci.nodejs.org/job/node-test-commit-arm-fanned/3571/

@tniessen
Copy link
Member Author

Landed in 47a0d04.

@tniessen tniessen closed this Sep 18, 2018
tniessen added a commit that referenced this pull request Sep 18, 2018
@tniessen
crypto: remove unused scrypt validation parameter
47a0d04 
PR-URL: #22902
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Sep 18, 2018
@tniessen @targos
crypto: remove unused scrypt validation parameter
7a5f2a3 
PR-URL: #22902
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Sep 18, 2018
Merged
@joyeecheung joyeecheung mentioned this pull request Sep 18, 2018
Closed
targos pushed a commit that referenced this pull request Sep 19, 2018
@tniessen @targos
crypto: remove unused scrypt validation parameter
2b0ce98 
PR-URL: #22902
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Sep 20, 2018
@tniessen @targos
crypto: remove unused scrypt validation parameter
329ac60 
PR-URL: #22902
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @nodejs-github-bot @Trott @danbev @addaleax @cjihrig