test: add dns.onlookupall() error test to increase coverage #22985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test that callback should be called when error occurs in dns.lookupall().
cjihrig
approved these changes
Sep 21, 2018
jasnell
approved these changes
Sep 21, 2018
addaleax
added
the
author ready
trivikr
approved these changes
Sep 25, 2018
|
Resumed build: https://ci.nodejs.org/job/node-test-pull-request/17422/ |
BridgeAR
approved these changes
Sep 25, 2018
| ); | ||
| assert.strictEqual(error.syscall, 'getaddrinfo'); | ||
| assert.strictEqual(error.hostname, addresses.INVALID_HOST); | ||
| })); |
There was a problem hiding this comment.
As a hint: it would be easier to write this as:
assert.throws(
() => dns.lookup(addresses.INVALID_HOST, {
hints: 0,
family: 0,
all: true
}),
{
code: 'ENOTFOUND',
message: 'getaddrinfo ENOTFOUND ...',
syscall: 'getaddrinfo',
hostname: addresses.INVALID_HOST
}
);
|
Landed in a58f377. |
danbev
pushed a commit
that referenced
this pull request
Sep 27, 2018
Added test that callback should be called when error occurs in dns.lookupall(). PR-URL: #22985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Sep 27, 2018
Added test that callback should be called when error occurs in dns.lookupall(). PR-URL: #22985 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test that callback should be called when error occurs in dns.lookupall().
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes