Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve instruction to purple merge #23007

Closed
wants to merge 3 commits into from

Conversation

refack
Copy link
Contributor

@refack refack commented Sep 21, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 21, 2018
@devsnek
Copy link
Member

devsnek commented Sep 21, 2018

I think you also need to push to your branch before you push to upstream. Can that be mentioned?

@refack
Copy link
Contributor Author

refack commented Sep 21, 2018

I think you also need to push to your branch before you push to upstream. Can that be mentioned?

Like in the line above that 😉

@refack refack added the meta Issues and PRs related to the general management of the project. label Sep 21, 2018
@devsnek
Copy link
Member

devsnek commented Sep 21, 2018

@refack i mean the explicit order. if you push to upstream before your branch it closes it but does it red instead of purple.

@refack
Copy link
Contributor Author

refack commented Sep 21, 2018

i mean the explicit order.

Gotcha

red closed status. If you close the PR before GitHub adjusts its status, it will
show up as a 0 commit PR and the changed file history will be empty. Also if you
push upstream before you push to your branch, GitHub will close the issue with
red status so the order of operations important.
Copy link
Member

@gireeshpunathil gireeshpunathil Sep 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably operations important -> operations is important. ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 25, 2018
@lundibundi
Copy link
Member

@danbev
Copy link
Contributor

danbev commented Sep 26, 2018

Landed in 938b269.

@danbev danbev closed this Sep 26, 2018
danbev pushed a commit that referenced this pull request Sep 26, 2018
PR-URL: #23007
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@refack refack deleted the tweak-instruction-to-purple branch September 26, 2018 17:21
@refack refack restored the tweak-instruction-to-purple branch September 26, 2018 17:21
@refack refack deleted the tweak-instruction-to-purple branch September 26, 2018 17:21
@refack refack restored the tweak-instruction-to-purple branch September 26, 2018 17:22
targos pushed a commit that referenced this pull request Sep 27, 2018
PR-URL: #23007
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants