-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add process.stdin.end() TTY regression test #23051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you also include a revert for my semver-major fix retaining tests? It should not be needed anymore (another PR is also ok).
@mcollina Will do, but another PR might be easier since it’s going to be |
I agree, ok!
Il giorno lun 24 set 2018 alle 11:18 Anna Henningsen <
notifications@github.com> ha scritto:
… @mcollina <https://github.com/mcollina> Will do, but another PR might be
easier since it’s going to be dont-land-on-v10.x…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23051 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADL45s-4Kx5XjQNr6YN6vveLcRNh3W0ks5ueKNsgaJpZM4W2SLd>
.
|
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17610/ ✔️ |
Landed in 9577946. |
PR-URL: #23051 Fixes: #22814 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #23051 Fixes: #22814 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #23051 Fixes: #22814 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Backport-PR-URL: #25351 PR-URL: #23051 Fixes: #22814 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs/node#23051 Fixes: nodejs/node#22814 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #22814
Taken from @mcollina’s #22900.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes