Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update guide for assert team #23085

Closed
wants to merge 1 commit into from
Closed

doc: update guide for assert team #23085

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 25, 2018

Update the Collaborator Guide to use the assert team for notifications
on assert module issues and pull requests.

/cc @BridgeAR

@nodejs/testing If anyone wants to be added to the team, let me know!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Update the Collaborator Guide to use the assert team for notifications
on assert module issues and pull requests.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 25, 2018
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 25, 2018
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 26, 2018
@Trott
Copy link
Member Author

Trott commented Sep 26, 2018

👍 this comment to fast-track.

@BridgeAR
Copy link
Member

@Trott I thought the testing group was actually explicitly not comparable to assert? I thought testing was more about fixing flaky tests and things like that?

@Trott
Copy link
Member Author

Trott commented Sep 27, 2018

Landed in 884dbe9

@Trott Trott closed this Sep 27, 2018
Trott added a commit to Trott/io.js that referenced this pull request Sep 27, 2018
Update the Collaborator Guide to use the assert team for notifications
on assert module issues and pull requests.

PR-URL: nodejs#23085
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 27, 2018
Update the Collaborator Guide to use the assert team for notifications
on assert module issues and pull requests.

PR-URL: #23085
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott Trott deleted the go-team branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants