Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test-gc-http-client-connaborted #23091

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 25, 2018

test-gc-http-client-connaborted is resource-intensive. It times out a lot on
CI. Move to sequential.

Labeling fast-track to fix flaky CI and because this is awfully easy to undo if someone comes up with a better solution. Please 👍 to approve fast-tracking.

(No Fixes: metadata on this one!)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 25, 2018
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 25, 2018
@Trott Trott changed the title test: improve test-gc-http-client-onerror test: improve test-gc-http-client-onaborted Sep 25, 2018
@Trott Trott changed the title test: improve test-gc-http-client-onaborted test: improve test-gc-http-client-connaborted Sep 25, 2018
test-gc-http-client-connaborted is resource-intensive. It times out a
lot on CI. Move to sequential.
@Trott Trott force-pushed the test-gc-http-client-connaborted branch from 2157914 to 0a77d8f Compare September 25, 2018 21:07
@Trott
Copy link
Member Author

Trott commented Sep 25, 2018

@addaleax
Copy link
Member

Just to be sure, is this test flaky? It invokes global.gc(); in a very different spot, which probably makes the test quite a bit faster and much more reliable?

@Trott
Copy link
Member Author

Trott commented Sep 25, 2018

I thought this one timed out for me with -j 32 --repeat 192, but let me double-check in case I ran a one of the other tests by accident.

FWIW, test-gc-tls-external-memory is not flaky for me.

@Trott
Copy link
Member Author

Trott commented Sep 25, 2018

Confirmed this one is flaky too. I can set up some stress tests if we want it documented/confirmed.

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, seems good :)

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 27, 2018
@Trott
Copy link
Member Author

Trott commented Sep 27, 2018

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/17469/ ✔️

@Trott
Copy link
Member Author

Trott commented Sep 27, 2018

Landed in 7603b4a

@Trott Trott closed this Sep 27, 2018
Trott added a commit to Trott/io.js that referenced this pull request Sep 27, 2018
test-gc-http-client-connaborted is resource-intensive. It times out a
lot on CI. Move to sequential.

PR-URL: nodejs#23091
Fixes: https://github.com/metadata
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 28, 2018
test-gc-http-client-connaborted is resource-intensive. It times out a
lot on CI. Move to sequential.

PR-URL: #23091
Fixes: https://github.com/metadata
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
targos pushed a commit that referenced this pull request Oct 3, 2018
test-gc-http-client-connaborted is resource-intensive. It times out a
lot on CI. Move to sequential.

PR-URL: #23091
Fixes: https://github.com/metadata
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants