-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: add no-strict-aliasing to ICU cflags #23112
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
i18n-api
Issues and PRs related to the i18n implementation.
tools
Issues and PRs related to the tools directory.
labels
Sep 27, 2018
addaleax
approved these changes
Sep 27, 2018
This commit adds -Wno-strict-aliasing to the icu_implementation target. The motivation for this is that this flags is enabled when building with macosx, and will make the output a little cleaner when building on other operating systems.
danbev
force-pushed
the
build_icu_linux
branch
from
September 28, 2018 03:24
8dc31db
to
8b1d874
Compare
FYI, I have a WIP PR #22920, part of is to ignore warnings on common.gypi | 1 -
node.gypi | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/common.gypi b/common.gypi
index e87bb0f5a4..4b436ac828 100644
--- a/common.gypi
+++ b/common.gypi
@@ -367,7 +367,6 @@
'ldflags': [ '-pthread' ],
}],
[ 'OS in "linux freebsd openbsd solaris android aix cloudabi"', {
- 'cflags': [ '-Wall', '-Wextra', '-Wno-unused-parameter', ],
'cflags_cc': [ '-fno-rtti', '-fno-exceptions', '-std=gnu++1y' ],
'ldflags': [ '-rdynamic' ],
'target_conditions': [
diff --git a/node.gypi b/node.gypi
index db29084335..15d8a02bcc 100644
--- a/node.gypi
+++ b/node.gypi
@@ -24,6 +24,7 @@
},
'force_load%': '<(force_load)',
},
+ 'cflags': [ '-Wall', '-Wextra', '-Wno-unused-parameter', ],
'conditions': [
[ 'node_shared=="false"', {
'msvs_settings': { |
jasnell
approved these changes
Oct 1, 2018
Re-run of failing node-test-commit-arm. |
Landed in f01adb5. |
danbev
added a commit
that referenced
this pull request
Oct 4, 2018
This commit adds -Wno-strict-aliasing to the icu_implementation target. The motivation for this is that this flags is enabled when building with macosx, and will make the output a little cleaner when building on other operating systems. PR-URL: #23112 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 5, 2018
This commit adds -Wno-strict-aliasing to the icu_implementation target. The motivation for this is that this flags is enabled when building with macosx, and will make the output a little cleaner when building on other operating systems. PR-URL: #23112 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 10, 2018
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
This commit adds -Wno-strict-aliasing to the icu_implementation target. The motivation for this is that this flags is enabled when building with macosx, and will make the output a little cleaner when building on other operating systems. PR-URL: #23112 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds -Wno-strict-aliasing to the icu_implementation target.
The motivation for this is that this flags is enabled when building with
macosx, and will make the output a little cleaner when building on
other operating systems.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes