Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: track file offset in writeFile of fs/promises #23136

Closed

Commits on Sep 27, 2018

  1. fs: track file offset in writeFile of fs/promises

    If the file offset is not tracked with `position` in the `write` calls
    all the data will be always written at the end of the file.
    
    This is problematic when we pass file descriptors to `writeFile` because
    the the file offset will not be updated. So, if some string is written
    to the FD with `writeFile` and if some other string is written to the
    same FD with `writeFile` without closing and reopening the file, the
    contents will be appended instead of writing from the beginning.
    thefourtheye committed Sep 27, 2018
    Configuration menu
    Copy the full SHA
    18d8c1e View commit details
    Browse the repository at this point in the history