Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: provide more V8 backwards compatibility #23158

Closed
wants to merge 4 commits into from

Commits on Oct 4, 2018

  1. Configuration menu
    Copy the full SHA
    3e3204f View commit details
    Browse the repository at this point in the history
  2. deps: revert 9136dd8088a9 from upstream V8

    Reverting this enables us to provide slower, but longer-lasting
    replacements for the deprecated APIs.
    
    Original commit message:
    
        Put back deleted V8_DEPRECATE_SOON methods
    
        This partially reverts
        https://chromium-review.googlesource.com/c/v8/v8/+/1177861,
        which deleted many V8_DEPRECATE_SOON methods rather than moving them to
        V8_DEPRECATED first. This puts them back and marks them V8_DEPRECATED.
    
        Note V8_DEPRECATED that were deleted in the same CL stay deleted.
    
        NOTRY=true
        NOPRESUBMIT=true
        NOTREECHECKS=true
    
        Bug: v8:7786, v8:8240
        Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
        Change-Id: I00330036d957f98dab403465b25e30d8382aac22
        Reviewed-on: https://chromium-review.googlesource.com/1251422
        Commit-Queue: Dan Elphick <delphick@chromium.org>
        Reviewed-by: Yang Guo <yangguo@chromium.org>
        Reviewed-by: Michael Hablich <hablich@chromium.org>
        Cr-Commit-Position: refs/branch-heads/7.0@{nodejs#49}
        Cr-Branched-From: 6e2adae6f7f8e891cfd01f3280482b20590427a6-refs/heads/7.0.276@{#1}
        Cr-Branched-From: bc08a8624cbbea7a2d30071472bc73ad9544eadf-refs/heads/master@{nodejs#55424}
    
    Refs: v8/v8@9136dd8
    Refs: nodejs#23122
    addaleax committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    a0fb221 View commit details
    Browse the repository at this point in the history
  3. deps: provide more V8 backwards compatibility

    Add back a number deprecated APIs, using shims that
    should work well enough at least for the duration of Node 11
    and do not come with significant maintenance overhead.
    
    Refs: nodejs#23122
    addaleax committed Oct 4, 2018
    Configuration menu
    Copy the full SHA
    7a0dd5b View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2018

  1. Configuration menu
    Copy the full SHA
    cf7bb97 View commit details
    Browse the repository at this point in the history