doc: simplify support section of README #23170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
force-pushed
the
simplify-support
branch
from
5d0e07e
to
40f9174
Compare
Make the Support section of the README file easier to read and understand.
Trott
force-pushed
the
simplify-support
branch
from
40f9174
to
94aaa3f
Compare
cjihrig
approved these changes
Sep 30, 2018
addaleax
approved these changes
Sep 30, 2018
| Remember, libre != gratis; the open source license grants you the freedom to use | ||
| and modify, but not commitments of other people's time. Please be respectful, | ||
| and set your expectations accordingly. | ||
| The open source license grants you the freedom to use Node.js. It does not |
There was a problem hiding this comment.
I think the and modify bit here could stay?
There was a problem hiding this comment.
My thinking was that the MIT license says all of this:
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
I understand why we'd select use from that list, but it's less clear why we'd also include modify over copy or distribute. Just sticking with use seemed simplest and best.
So that was my thinking. If that's not persuasive, I'll restore and modify to the text.
There was a problem hiding this comment.
Maybe /s/modify/fix/ might give the reader the hint we imply ;)
(or "tweak")
There was a problem hiding this comment.
@Trott That’s okay with me, yeah… I guess I’ve thought that modify would be the least likely of the verbs you used for which it would be assumed that it’s okay to do?
refack
approved these changes
Sep 30, 2018
vsemozhetbyt
approved these changes
Sep 30, 2018
tniessen
approved these changes
Sep 30, 2018
lpinca
approved these changes
Sep 30, 2018
trivikr
approved these changes
Oct 1, 2018
jasnell
approved these changes
Oct 1, 2018
BridgeAR
approved these changes
Oct 1, 2018
Trott
added
the
author ready
|
Landed in 37e8381 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 3, 2018
Make the Support section of the README file easier to read and understand. PR-URL: nodejs#23170 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Oct 3, 2018
Make the Support section of the README file easier to read and understand. PR-URL: #23170 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Oct 10, 2018
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Make the Support section of the README file easier to read and understand. PR-URL: #23170 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the Support section of the README file easier to read and
understand.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes