Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve Release Types text in README #23190

Closed
wants to merge 3 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 1, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Simplify text and improve clarity.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 1, 2018
README.md Outdated
each year will convert to LTS (see below) after 6 months and receive further
support for 30 months.
All releases follow [Semantic Versioning](https://semver.org). A member of the
Release Team](#release-team) signs each release.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing [

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Michaël's comment addressed.

beginning with v4 Argon. There are no breaking changes or feature additions,
except in some special circumstances.
* **Nightly**: Code from the Current branch built every 24-hours when there are
changes. Use with caution.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://nodejs.org/download/nightly/ lists a large number of v11.x nightlies. That would sound to me like they’re not building from the Current branch (v10.x), but from master?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are nightlies for both Current and master branches.

@vsemozhetbyt
Copy link
Contributor

Is it worth to add a line for https://nodejs.org/download/v8-canary/ ?

@Trott
Copy link
Member Author

Trott commented Oct 1, 2018

Is it worth to add a line for https://nodejs.org/download/v8-canary/ ?

@vsemozhetbyt I'm inclined to say "no" for this section. I'm not even sure that qualifies as a release as much as it qualifies as an artifact we build. While the V8 Canary should be documented somewhere, this section should not be comprehensive. It should just have the things that are likely to be of interest to most users: Current, LTS, Nightly. (TBH, I'm even on the fence about including Nightly, but I didn't want to make any changes that might be controversial in this PR.)

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 2, 2018
Trott added a commit to Trott/io.js that referenced this pull request Oct 3, 2018
Simplify text and improve clarity.

PR-URL: nodejs#23190
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott
Copy link
Member Author

Trott commented Oct 3, 2018

Landed in 1f780be

jasnell pushed a commit that referenced this pull request Oct 17, 2018
Simplify text and improve clarity.

PR-URL: #23190
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott Trott deleted the simplify-release-types branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.