-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: improve Release Types text in README #23190
Conversation
Simplify text and improve clarity.
README.md
Outdated
each year will convert to LTS (see below) after 6 months and receive further | ||
support for 30 months. | ||
All releases follow [Semantic Versioning](https://semver.org). A member of the | ||
Release Team](#release-team) signs each release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing [
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with Michaël's comment addressed.
beginning with v4 Argon. There are no breaking changes or feature additions, | ||
except in some special circumstances. | ||
* **Nightly**: Code from the Current branch built every 24-hours when there are | ||
changes. Use with caution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://nodejs.org/download/nightly/ lists a large number of v11.x nightlies. That would sound to me like they’re not building from the Current branch (v10.x), but from master
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are nightlies for both Current and master branches.
Is it worth to add a line for https://nodejs.org/download/v8-canary/ ? |
@vsemozhetbyt I'm inclined to say "no" for this section. I'm not even sure that qualifies as a release as much as it qualifies as an artifact we build. While the V8 Canary should be documented somewhere, this section should not be comprehensive. It should just have the things that are likely to be of interest to most users: Current, LTS, Nightly. (TBH, I'm even on the fence about including Nightly, but I didn't want to make any changes that might be controversial in this PR.) |
Simplify text and improve clarity. PR-URL: nodejs#23190 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Landed in 1f780be |
Simplify text and improve clarity. PR-URL: #23190 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Simplify text and improve clarity. PR-URL: #23190 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes