Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x] backport commits #23226

Closed
wants to merge 2 commits into from
Closed

[v10.x] backport commits #23226

wants to merge 2 commits into from

Commits on Oct 3, 2018

  1. assert: improve diff output 

    The output is now a tiny bit improved by sorting object properties
when inspecting the values that are compared with each other. That
reduces the overall diff for identical objects with a different
property insertion order.

PR-URL: nodejs#22788
Refs: nodejs#22763
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    @BridgeAR
    BridgeAR committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    8dcf60b View commit details
    Browse the repository at this point in the history

  2. util: move inspect in separate file 

    The inspect function became very big and it's better to handle this
in a separate file.

PR-URL: nodejs#22845
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @BridgeAR
    BridgeAR committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    a666cb7 View commit details
    Browse the repository at this point in the history