Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icu: make process.binding('icu') internal #23234

Merged
merged 3 commits into from
Oct 9, 2018
Merged

Commits on Oct 9, 2018

  1. test: remove test-buffer-bindingobj-no-zerofill.js

    PR-URL: nodejs#23234
    Refs: nodejs#22160
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    starkwang authored and cjihrig committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    9930529 View commit details
    Browse the repository at this point in the history
  2. icu: make process.binding('icu') internal

    PR-URL: nodejs#23234
    Refs: nodejs#22160
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    cjihrig committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    2498c7b View commit details
    Browse the repository at this point in the history
  3. buffer: unconditionally use internalBinding

    With the removal of test-buffer-bindingobj-no-zerofill.js,
    internalBinding can be used unconditionally to assign
    isAnyArrayBuffer().
    
    PR-URL: nodejs#23234
    Refs: nodejs#22160
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    cjihrig committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    2ec57a7 View commit details
    Browse the repository at this point in the history