Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update author-ready label terms #23249

Closed
wants to merge 1 commit into from
Closed

doc: update author-ready label terms #23249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,11 @@ necessary.
### Author ready pull requests

A pull request that is still awaiting the minimum review time is considered
_author ready_ as soon as the CI has been started, it has at least one approval,
and it has no outstanding review comments. Please always make sure to add the
`author ready` label to the PR in that case and remove it again as soon as that
condition is not met anymore.
_author ready_ as soon as the CI has been started, it has at least two approvals
(one Collaborator approval is enough if the pull request has been open for more
than 7 days), and it has no outstanding review comments. Please always make sure
to add the `author ready` label to the PR in that case and remove it again as
soon as that condition is not met anymore.

### Handling own pull requests

Expand Down
3 changes: 2 additions & 1 deletion doc/onboarding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ onboarding session.
* Please add the `author-ready` label for PRs where:
* the CI has been started (not necessarily finished),
* no outstanding review comments exist and
* at least one collaborator approved the PR.
* at least two Collaborators approved the PR (one Collaborator approval is
enough if the pull request has been open for more than 7 days).

* See [Who to CC in the issue tracker][who-to-cc].
* This will come more naturally over time
Expand Down