Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix compiler warning in doc/api/addons.md #23323

Closed
wants to merge 2 commits into from
Closed

test: fix compiler warning in doc/api/addons.md #23323

wants to merge 2 commits into from

Commits on Oct 9, 2018

  1. test: fix compiler warning in addons/02_callbacks 

    Currently the following compiler warning is emitted:
../addon.cc:17:58:
warning: 'ToString' is deprecated:
Use maybe version [-Wdeprecated-declarations]
obj->Set(String::NewFromUtf8(isolate, "msg"),
                             args[0]->ToString(isolate));
                                                         ^
deps/v8/include/v8.h:2537:3:
note: 'ToString' has been explicitly marked deprecated here
  V8_DEPRECATED("Use maybe version",
  ^

This commit updates example to use the non-deprecated version.
    @danbev
    danbev committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    6e1fdb8 View commit details
    Browse the repository at this point in the history

  2. squash: fix compiler warning 07_passing_wrapped_ob 

    Currently the following compiler warning is emitted:
1 warning generated.
../addon.cc:24:16:
warning: 'ToObject' is deprecated:
Use maybe version [-Wdeprecated-declarations]
      args[0]->ToObject(isolate));
               ^
./deps/v8/include/v8.h:2539:3:
note: 'ToObject' has been explicitly marked deprecated here
  V8_DEPRECATED("Use maybe version",
  ^

This commit updates example to use the non-deprecated version.
    @danbev
    danbev committed Oct 9, 2018
    Configuration menu
    Copy the full SHA
    0a0dc00 View commit details
    Browse the repository at this point in the history