doc: rewrite consensus seeking in guide #23349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite the Consensus Seeking section of the Collaborators Guide for easier reading, more clarity, shorter sentences, less passive voice, etc.
thefourtheye
approved these changes
Oct 9, 2018
vsemozhetbyt
approved these changes
Oct 9, 2018
vsemozhetbyt
added
the
author ready
trivikr
approved these changes
Oct 9, 2018
jasnell
reviewed
Oct 9, 2018
COLLABORATOR_GUIDE.md
Outdated
| Collaborators should not block pull requests without providing a reason. Other | ||
| Collaborators may ask objecting Collaborators questions about their objections. | ||
| If an objecting Collaborator is unresponsive, another Collaborator may dismiss | ||
| their objection. |
There was a problem hiding this comment.
Collaborators should not block a pull request without providing a reason.
Questions may be asked about why a collaborator objects. If the objector
is unresponsive, the objection may be dismissed.
There was a problem hiding this comment.
Not for this PR, but: timeslot?
There was a problem hiding this comment.
Also, this new wording (in PR) could cause confusion.
Other Collaborators may ask objecting Collaborators questions about their objections.
If an objecting Collaborator is unresponsive, another Collaborator may dismiss their objection.
This could be read as if any objection could be dismissed after the objector becomes unresponsive, even if they feel that they answered all questions already.
The variant that @jasnell proposed is better, but I would prefer to keep the «Note that this does not apply to objections that are explained.» part.
There was a problem hiding this comment.
The original text did have the loose within a reasonable period of time.
jasnell
reviewed
Oct 9, 2018
COLLABORATOR_GUIDE.md
Outdated
| If an objecting Collaborator is unresponsive, another Collaborator may dismiss | ||
| their objection. | ||
|
|
||
| Note that [breaking changes](#breaking-changes) must receive |
There was a problem hiding this comment.
[Breaking](#breaking-changes) (`semver-major`) must receive
[TSC review](#involving-the-tsc). If two TSC members approve
the pull request and no Collaborators object, then it may land.
If there are objections, the TSC may be asked to give additional
consideration (by adding the `tsc-review` label), or the pull
request may be put on the TSC meeting agenda (by adding the
`tsc-agenda` label).
|
Updated for nits. PTAL |
|
Landed in d4ce144 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 11, 2018
Rewrite the Consensus Seeking section of the Collaborators Guide for easier reading, more clarity, shorter sentences, less passive voice, etc. PR-URL: nodejs#23349 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 12, 2018
Rewrite the Consensus Seeking section of the Collaborators Guide for easier reading, more clarity, shorter sentences, less passive voice, etc. PR-URL: #23349 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Rewrite the Consensus Seeking section of the Collaborators Guide for easier reading, more clarity, shorter sentences, less passive voice, etc. PR-URL: #23349 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 30, 2018
Rewrite the Consensus Seeking section of the Collaborators Guide for easier reading, more clarity, shorter sentences, less passive voice, etc. PR-URL: #23349 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Closed
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Rewrite the Consensus Seeking section of the Collaborators Guide for easier reading, more clarity, shorter sentences, less passive voice, etc. PR-URL: #23349 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Rewrite the Consensus Seeking section of the Collaborators Guide for easier reading, more clarity, shorter sentences, less passive voice, etc. PR-URL: #23349 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the Consensus Seeking section of the Collaborators Guide for
easier reading, more clarity, shorter sentences, less passive voice,
etc.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes