util: reduce inspection depth default to five #23350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To minimize potential problems with the higher `util.inspect()` depth default it is lowered to five as a intermediate step.
nodejs-github-bot
added
the
util
thefourtheye
approved these changes
Oct 9, 2018
silverwind
approved these changes
Oct 9, 2018
devsnek
approved these changes
Oct 9, 2018
BridgeAR
added
the
author ready
lundibundi
approved these changes
Oct 9, 2018
|
Maybe I'm confused about where this default is used, but since this is changing the default depth, doesn't this PR have to touch the docs where it describes the default depth as 20? |
|
@sam-github absolutely! I totally overlooked to change that again. |
|
@BridgeAR Looks like this needs a rebase? |
addaleax
removed
the
author ready
|
This will need to land by Saturday in order to make it in to 11.0.0 |
|
can this please make it into a 11x release. |
4 tasks
|
Since the change this builds on was reverted, should this be closed? Or rebased? Opened as a new PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To minimize potential problems with the higher
util.inspect()depth default it is lowered to five as a intermediate step.I added the don't-land-on labels instead of marking this as semver-major since this relies on a semver-major commit.
Refs: #22846 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes