[v10.x backport] backport 23233, 22938 #23398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
2 tasks
thefourtheye
approved these changes
Oct 10, 2018
ofrobots
changed the title
|
To reduce blocking, I added the back port of #22938 to this PR as well. |
2 tasks
ofrobots
force-pushed
the
backport-10-23233
branch
from
5bbcece
to
3a00a4f
Compare
Make sure background workers are ready before proceeding with the bootstrap or post-bootstrap execution of any code that may trigger `process.exit()`. Fixes: nodejs#23065 PR-URL: nodejs#23233 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
For safer shutdown, we should destroy the platform – and background threads - before the tracing infrastructure is destroyed. This change fixes the relative order of NodePlatform disposition and the tracing agent shutting down. This matches the nesting order for startup. Make the tracing agent own the tracing controller instead of platform to match the above. Fixes: nodejs#22865 PR-URL: nodejs#22938 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
ofrobots
force-pushed
the
backport-10-23233
branch
from
3a00a4f
to
afca579
Compare
targos
approved these changes
Oct 13, 2018
|
CI is green. |
Trott
added
the
author ready
|
@ofrobots not a big deal, but commits from backport PR should have a |
|
Sorry about that. I'll keep it in mind for the next one. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #23233 and #22938.
CI:
https://ci.nodejs.org/job/node-test-pull-request/17718/https://ci.nodejs.org/job/node-test-pull-request/17724/