-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: move more deprecations to V8_DEPRECATED #23414
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
v8 engine
Issues and PRs related to the V8 dependency.
labels
Oct 10, 2018
addaleax
added
the
semver-minor
PRs that contain new features and should be released in the next minor version.
label
Oct 10, 2018
Is it really more efficient to keep floating patches when we can turn on common.gypi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/common.gypi b/common.gypi
index 4c43db48f3..564ec316a8 100644
--- a/common.gypi
+++ b/common.gypi
@@ -264,6 +264,10 @@
}
}
},
+ 'defines': [
+ 'V8_DEPRECATION_WARNINGS',
+ 'V8_IMMINENT_DEPRECATION_WARNINGS',
+ ],
# Forcibly disable -Werror. We support a wide range of compilers, it's
# simply not feasible to squelch all warnings, never mind that the
# libraries in deps/ are not under our control.
|
@refack How much compiler warning output would we currently get with those settings? |
Just from
We can also consider setting it only for the "SDK" (i.e. |
This was referenced Oct 11, 2018
jasnell
approved these changes
Oct 12, 2018
2 tasks
refack
pushed a commit
to RomainForks/node
that referenced
this pull request
Oct 23, 2018
Refs: nodejs#23414 (comment) PR-URL: nodejs#23804 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
These APIs have been deprecated upstream in V8.
addaleax
force-pushed
the
v8-dep-again
branch
from
October 24, 2018 10:45
db5fd3e
to
f12d0af
Compare
addaleax
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Oct 24, 2018
targos
pushed a commit
that referenced
this pull request
Oct 24, 2018
Refs: #23414 (comment) PR-URL: #23804 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 4fe0bb3 |
addaleax
added a commit
that referenced
this pull request
Oct 25, 2018
These APIs have been deprecated upstream in V8. PR-URL: #23414 Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 26, 2018
These APIs have been deprecated upstream in V8. PR-URL: #23414 Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 1, 2018
These APIs have been deprecated upstream in V8. PR-URL: #23414 Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 2, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Nov 26, 2018
Refs: #23414 (comment) PR-URL: #23804 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 28, 2018
Refs: #23414 (comment) PR-URL: #23804 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Refs: #23414 (comment) PR-URL: #23804 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
build
Issues and PRs related to build files or the CI.
semver-minor
PRs that contain new features and should be released in the next minor version.
v8 engine
Issues and PRs related to the V8 dependency.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These APIs have been deprecated upstream in V8.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes