Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 7.1 #23423

Closed
wants to merge 11 commits into from
Closed

deps: update V8 to 7.1 #23423

wants to merge 11 commits into from

Commits on Dec 4, 2018

  1. deps: update V8 to 7.1.302.28

    @targos
    targos committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    e45b2e4 View commit details
    Browse the repository at this point in the history

  2. build: reset embedder string to "-node.0"

    @targos
    targos committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    c43cd86 View commit details
    Browse the repository at this point in the history

  3. src: update NODE_MODULE_VERSION to 68 

    Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 7.1.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
    @targos
    targos committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    546f5a9 View commit details
    Browse the repository at this point in the history

  4. deps: sync V8 gypfiles with 7.1 

    Rnable v8_enable_embedded_builtins.
Reorder conditions proccessing for `run_mksnapshot`.

deps,v8: link with `atomic` for platforms lacking CAS
Fixes: nodejs/node-v8#81

Co-authored-by: Michaël Zasso <targos@protonmail.com>
    @refack @targos
    refack and targos committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    9da61bd View commit details
    Browse the repository at this point in the history

  5. deps: cherry-pick 0483e9a from upstream V8 

    Original commit message:

    [api] Allow embedder to construct an Array from Local<Value>*

    Currently to obtain a v8::Array out of a C array or a std::vector,
    one needs to loop through the elements and call array->Set() multiple
    times, and these calls go into v8::Object::Set() which can be slow.
    This patch adds a new Array::New overload that converts a
    Local<Value>* with known size into a Local<Array>.

    Change-Id: I0a768f0e18eec51e78d58be455482ec6425ca188
    Reviewed-on: https://chromium-review.googlesource.com/c/1317049
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#57261}

Refs: v8/v8@0483e9a

PR-URL: nodejs#24125
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @joyeecheung @targos
    joyeecheung authored and targos committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    78b1437 View commit details
    Browse the repository at this point in the history

  6. deps: cherry-pick b87d408 from upstream V8 

    Original commit message:

    [heap-profiler] Fix a use-after-free when snapshots are deleted

    If a caller starts the sampling heap profiler and takes a snapshot,
    and then deletes the snapshot before the sampling has completed, a
    use-after-free will occur on the StringsStorage pointer.

    The same issue applies for StartTrackingHeapObjects which shares the
    same StringsStorage object.

    Bug: v8:8373
    Change-Id: I5d69d60d3f9465f9dd3b3bef107c204e0fda0643
    Reviewed-on: https://chromium-review.googlesource.com/c/1301477
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: Alexei Filippov <alph@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57114}

PR-URL: nodejs#24272
Refs:
v8/v8@b87d408
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    @psmarshall @targos
    psmarshall authored and targos committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    bbcf8e6 View commit details
    Browse the repository at this point in the history

  7. deps: cherry-pick 073073b from upstream V8 

    Original commit message:

    [profiler] introduce API to enable detailed source positions

    This allows Node.js to enable detailed source positions for optimized code
    early on, without having to pass a flag string.

    R=petermarshall@chromium.org

    Change-Id: Ie74ea41f600cf6e31acbe802116df4976ccf1c75
    Reviewed-on: https://chromium-review.googlesource.com/c/1319757
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57380}

Refs: v8/v8@073073b

PR-URL: nodejs#24515
Refs: nodejs#24274
Refs: nodejs#24394
Refs: nodejs#24393
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Peter Marshall <petermarshall@chromium.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @hashseed @targos
    hashseed authored and targos committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    cbce4e4 View commit details
    Browse the repository at this point in the history

  8. deps: cherry-pick 88f8fe1 from upstream V8 

    Original commit message:

    Fix collection iterator preview with deleted entries

    We used to assume that we know the remaining entries returned by the
    iterator based on the current index. However, that is not accurate,
    since entries skipped by the current index could be deleted.

    In the new approach, we allocate conservatively and shrink the result.

    R=neis@chromium.org

    Bug: v8:8433
    Change-Id: I38a3004dc3af292daabb454bb76f38d65ef437e8
    Reviewed-on: https://chromium-review.googlesource.com/c/1325966
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Georg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57360}

Refs: v8/v8@88f8fe1

PR-URL: nodejs#24514
Refs: nodejs#24053
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @hashseed @targos
    hashseed authored and targos committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    977fd14 View commit details
    Browse the repository at this point in the history

  9. test: update postmortem metadata test for V8 7.1 

    The V8 7.1 update requires the following adjustments to the
postmortem debugging metadata constants:

- v8dbg_class_JSArrayBuffer__byte_length__Object
  Use: v8dbg_class_JSArrayBuffer__byte_length__size_t

- v8dbg_class_JSArrayBufferView__raw_byte_length__Object
  Use: v8dbg_class_JSArrayBufferView__byte_length__size_t

- v8dbg_class_JSArrayBufferView__raw_byte_offset__Object
  Use: v8dbg_class_JSArrayBufferView__byte_offset__size_t

- v8dbg_class_String__length__SMI
  Use: v8dbg_class_String__length__int32_t

Refs: v8/v8@5cfe1a6
Refs: v8/v8@c7a0049
    @cjihrig @targos
    cjihrig authored and targos committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    ec0dea2 View commit details
    Browse the repository at this point in the history

  10. src: update postmortem constant 

    Update a postmortem constant used by the ustack helper which
changed while moving to V8 7.1.
    @cjihrig @targos
    cjihrig authored and targos committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    9ee6d39 View commit details
    Browse the repository at this point in the history

  11. src: explicitly allow JS in ReadHostObject

    @hashseed @targos
    hashseed authored and targos committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    f4a5465 View commit details
    Browse the repository at this point in the history