Commits on Oct 25, 2018

1. lib: make the global console [[Prototype]] an empty object …

   From the WHATWG console spec:
   
   > For historical web-compatibility reasons, the namespace object for
   > console must have as its [[Prototype]] an empty object, created as
   > if by ObjectCreate(%ObjectPrototype%), instead of %ObjectPrototype%.
   
   Since in Node.js, the Console constructor has been exposed through
   require('console'), we need to keep the Console constructor but
   we cannot actually use `new Console` to construct the global console.
   
   This patch changes the prototype chain of the global console object,
   so the console.Console.prototype is not in the global console prototype
   chain anymore.
   
   ```
   const proto = Object.getPrototypeOf(global.console);
   // Before this patch
   proto.constructor === global.console.Console
   // After this patch
   proto.constructor === Object
   ```
   
   But, we still maintain that
   
   ```
   global.console instanceof global.console.Console
   ```
   
   through a custom Symbol.hasInstance function of Console that tests
   for a special symbol kIsConsole for backwards compatibility.
   
   This fixes a case in the console Web Platform Test that we commented
   out.
   
   Refs: https://console.spec.whatwg.org/#console-namespace
   Refs: whatwg/console#3

   

   joyeecheung committed Oct 25, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 5556e47
   • Browse repository at this point

   Copy the full SHA

   5556e47 View commit details

   Browse the repository at this point in the history