Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix assert.strictEqual() parameter order #23587

Closed
wants to merge 1 commit into from
Closed

test: fix assert.strictEqual() parameter order #23587

wants to merge 1 commit into from

Conversation

blakehall
Copy link
Contributor

@blakehall blakehall commented Oct 12, 2018 •
edited by BridgeAR
Loading

The argument order in the strictEqual check was in the wrong order.
The first argument is now the actual value and the second argument is
the expected value.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

test: fix assert.strictEqual() parameter order in test-path-maklong.js
9508285 
The argument order in the strictEqual check was in the wrong order.
The first argument is now the actual value and the second argument is
the expected value.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018
@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
@BridgeAR BridgeAR changed the title test: fix assert.strictEqual() parameter order in test-path-maklong.js test: fix assert.strictEqual() parameter order Oct 12, 2018
@addaleax addaleax added the path Issues and PRs related to the path subsystem. label Oct 12, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@BridgeAR
test: fix assert.strictEqual() parameter order in test-path-maklong.js
37faa98 
The argument order in the strictEqual check was in the wrong order.
The first argument is now the actual value and the second argument is
the expected value.

PR-URL: nodejs#23587
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@BridgeAR
test: fix assert.strictEqual() parameter order in test-path-maklong.js
c30658c 
The argument order in the strictEqual check was in the wrong order.
The first argument is now the actual value and the second argument is
the expected value.

PR-URL: nodejs#23587
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@BridgeAR
Copy link
Member

Landed in c30658c 🎉

@blakehall congratulations on your commit to Node.js!

@BridgeAR BridgeAR closed this Oct 15, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@jasnell
test: fix assert.strictEqual() parameter order in test-path-maklong.js
99a7e25 
The argument order in the strictEqual check was in the wrong order.
The first argument is now the actual value and the second argument is
the expected value.

PR-URL: #23587
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@addaleax
test: fix assert.strictEqual() parameter order in test-path-maklong.js
84c6353 
The argument order in the strictEqual check was in the wrong order.
The first argument is now the actual value and the second argument is
the expected value.

PR-URL: #23587
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@MylesBorins
test: fix assert.strictEqual() parameter order in test-path-maklong.js
c9ba20a 
The argument order in the strictEqual check was in the wrong order.
The first argument is now the actual value and the second argument is
the expected value.

PR-URL: #23587
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@rvagg
test: fix assert.strictEqual() parameter order in test-path-maklong.js
ca331e8 
The argument order in the strictEqual check was in the wrong order.
The first argument is now the actual value and the second argument is
the expected value.

PR-URL: #23587
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@MylesBorins
test: fix assert.strictEqual() parameter order in test-path-maklong.js
38b6fff 
The argument order in the strictEqual check was in the wrong order.
The first argument is now the actual value and the second argument is
the expected value.

PR-URL: #23587
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. path Issues and PRs related to the path subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@blakehall @BridgeAR @jasnell @thefourtheye @cjihrig @gireeshpunathil @trivikr @addaleax @targos @nodejs-github-bot