Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: convertProtocols() error handling #23606

Commits on Oct 12, 2018

  1. tls: convertProtocols() error handling

    The convertProtocols() function now throws a range error when the byte
    length of a protocol is too long to fit in a Buffer.
    
    Also added a test case in test/parallel/test-tls-basic-validations.js
    to cover this.
    Andre Jodat-Danbrani committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    c72e9c3 View commit details
    Browse the repository at this point in the history
  2. tls: convertProtocols() amended an error message

    Changed the byte length error message for protocol to correctly state
    that the length must be <= 255 not < 255
    
    Amended the test case in test/parallel/test-tls-basic-validations.js
    Andre Jodat-Danbrani committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    85d2428 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2018

  1. lib: added override for msg in ERR_OUT_OF_RANGE

    Also changed corresponding usage in lib/tls.js
    
    Amended the test case in test/parallel/test-tls-basic-validations.js
    Andre Jodat-Danbrani committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    5c4e7d8 View commit details
    Browse the repository at this point in the history
  2. tls: minor change to error message in convertProtocols()

    Andre Jodat-Danbrani committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    951692e View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2018

  1. lib: refactored the signature of ERROR_OUT_OF_RANGE

    Andre Jodat-Danbrani committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    ca17a24 View commit details
    Browse the repository at this point in the history