test: add test coverage for fs.truncate #23620

christian-bromann · 2018-10-12T19:05:44Z

Add test to check:

for null as len parameter
if error is propagated into callback if file doesn't exist
if an error is actually thrown if len is not a number

I think it is safe to say that we could remove:

  } else if (len === undefined) {
    len = 0;
  }

because there is an validateInteger(len, 'len'); right after. Another option would be to just set len to 0 for all cases it is not a Number. What do you think?

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

refack · 2018-10-12T19:08:23Z

Hello @christian-bromann and thank you for the contribution 🥇

refack · 2018-10-12T19:14:06Z

the following:

node/lib/fs.js

Lines 617 to 622 in bcbb937

    
           if (typeof len === 'function') { 
        
             callback = len; 
        
             len = 0; 
        
           } else if (len === undefined) { 
        
             len = 0; 
        
           }

Is a sort of JS idiom to handle optional function arguments. IMHO it could stay as as.

trivikr · 2018-10-13T03:33:33Z

CI (pending): https://ci.nodejs.org/job/node-test-pull-request/17796/

thefourtheye · 2018-10-13T09:10:54Z

test/parallel/test-fs-truncate.js

+{
+  const file8 = path.resolve(tmp, 'truncate-file-8.txt');
+  fs.truncate(file8, 0, common.mustCall(function(err) {
+    assert.ok(err);


If we are expecting an error, its bettor to explicitly assert the error. But, I think you meant to write assert.ifError here.

Since this passes CI, I'm assuming it fails with code ENOENT.
Assertion should have been near

node/test/parallel/test-fs-error-messages.js

Lines 521 to 545 in 9f7e3a4

// ftruncate

{

const validateError = (err) => {

assert.strictEqual(err.syscall, 'ftruncate');

// Could be EBADF or EINVAL, depending on the platform

if (err.code === 'EBADF') {

assert.strictEqual(err.message, 'EBADF: bad file descriptor, ftruncate');

assert.strictEqual(err.errno, UV_EBADF);

} else {

assert.strictEqual(err.message, 'EINVAL: invalid argument, ftruncate');

assert.strictEqual(err.errno, UV_EINVAL);

assert.strictEqual(err.code, 'EINVAL');

}

return true;

};

common.runWithInvalidFD((fd) => {

fs.ftruncate(fd, 4, common.mustCall(validateError));

assert.throws(

() => fs.ftruncateSync(fd, 4),

validateError

);

});

}

But since it's not, I agree it should be here.

christian-bromann · 2018-10-15T16:58:03Z

@thefourtheye added explicit check for error

refack · 2018-10-15T17:12:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/17871/

lundibundi · 2018-10-15T17:11:45Z

test/parallel/test-fs-truncate.js

+}
+
+{
+  const file8 = path.resolve(tmp, 'truncate-file-8.txt');


Nit: maybe use some more descriptive filename that will indicate that this file is indeed non-existent and make sure that nobody creates it accidentally (via other test), perhaps: 'non-existent-truncate-file.txt'?

thefourtheye · 2018-10-15T17:54:18Z

test/parallel/test-fs-truncate.js

+      code: 'ERR_INVALID_ARG_TYPE',
+      name: 'TypeError [ERR_INVALID_ARG_TYPE]',
+      message: 'The "len" argument must be of type number. ' +
+                `Received type ${typeof input}`


Nit: this line should be aligned to the '

christian-bromann · 2018-10-15T21:23:24Z

It says Missing subsystem. which is odd because I started the commit with test:...

addaleax · 2018-10-15T21:26:43Z

/cc @Trott

@christian-bromann It’s not the first time that that happened, but I think we thought we had fixed it. I don’t think you need to do anything here, though.

CI: https://ci.nodejs.org/job/node-test-pull-request/17877/

christian-bromann · 2018-10-15T22:31:47Z

Maybe to add context to this situation: I used git commit --amend for all changes that happen after I made the initial PR

Add test to check: - for `null` as len parameter - if error is propagated into callback if file doesn't exist - if an error is actually thrown if len is not a number PR-URL: nodejs#23620 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

refack · 2018-10-15T23:03:01Z

Landed in 74f854e 🎉
Congratulations @christian-bromann on GitHub promoting you form

to

Hope we see you contributing more in the future 😉

christian-bromann · 2018-10-15T23:07:03Z

Hope we see you contributing more in the future 😉

Will try my best. Thanks for the support. I really enjoyed the code and learn session at Node+JS Interactive.

Add test to check: - for `null` as len parameter - if error is propagated into callback if file doesn't exist - if an error is actually thrown if len is not a number PR-URL: #23620 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018

refack approved these changes Oct 12, 2018

View reviewed changes

refack added the fs Issues and PRs related to the fs subsystem / file system. label Oct 12, 2018

BridgeAR approved these changes Oct 12, 2018

View reviewed changes

BridgeAR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018

jasnell approved these changes Oct 12, 2018

View reviewed changes

trivikr approved these changes Oct 13, 2018

View reviewed changes

gireeshpunathil approved these changes Oct 13, 2018

View reviewed changes

thefourtheye suggested changes Oct 13, 2018

View reviewed changes

christian-bromann force-pushed the truncate-test-coverage branch from 13a578a to 7299332 Compare October 15, 2018 16:57

lundibundi approved these changes Oct 15, 2018

View reviewed changes

thefourtheye approved these changes Oct 15, 2018

View reviewed changes

christian-bromann force-pushed the truncate-test-coverage branch from 7299332 to 2a1b66d Compare October 15, 2018 18:48

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 15, 2018

refack force-pushed the truncate-test-coverage branch from 2a1b66d to 106a6ed Compare October 15, 2018 22:58

refack force-pushed the truncate-test-coverage branch from 106a6ed to 74f854e Compare October 15, 2018 22:59

refack merged commit 74f854e into nodejs:master Oct 15, 2018

christian-bromann deleted the truncate-test-coverage branch October 15, 2018 23:05

codebytere mentioned this pull request Nov 27, 2018

v10.13.1 proposal #24675

Closed

codebytere mentioned this pull request Nov 29, 2018

v10.14.2 proposal #24727

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add test coverage for fs.truncate #23620

test: add test coverage for fs.truncate #23620

christian-bromann commented Oct 12, 2018 •

edited

Loading

refack commented Oct 12, 2018

refack commented Oct 12, 2018

trivikr commented Oct 13, 2018

thefourtheye Oct 13, 2018

refack Oct 13, 2018

christian-bromann commented Oct 15, 2018

refack commented Oct 15, 2018

lundibundi Oct 15, 2018

thefourtheye Oct 15, 2018

christian-bromann commented Oct 15, 2018

addaleax commented Oct 15, 2018

christian-bromann commented Oct 15, 2018

refack commented Oct 15, 2018

christian-bromann commented Oct 15, 2018

	// ftruncate
	{
	const validateError = (err) => {
	assert.strictEqual(err.syscall, 'ftruncate');
	// Could be EBADF or EINVAL, depending on the platform
	if (err.code === 'EBADF') {
	assert.strictEqual(err.message, 'EBADF: bad file descriptor, ftruncate');
	assert.strictEqual(err.errno, UV_EBADF);
	} else {
	assert.strictEqual(err.message, 'EINVAL: invalid argument, ftruncate');
	assert.strictEqual(err.errno, UV_EINVAL);
	assert.strictEqual(err.code, 'EINVAL');
	}
	return true;
	};

	common.runWithInvalidFD((fd) => {
	fs.ftruncate(fd, 4, common.mustCall(validateError));

	assert.throws(
	() => fs.ftruncateSync(fd, 4),
	validateError
	);
	});
	}

test: add test coverage for fs.truncate #23620

test: add test coverage for fs.truncate #23620

Conversation

christian-bromann commented Oct 12, 2018 • edited Loading

Checklist

refack commented Oct 12, 2018

refack commented Oct 12, 2018

trivikr commented Oct 13, 2018

thefourtheye Oct 13, 2018

Choose a reason for hiding this comment

refack Oct 13, 2018

Choose a reason for hiding this comment

christian-bromann commented Oct 15, 2018

refack commented Oct 15, 2018

lundibundi Oct 15, 2018

Choose a reason for hiding this comment

thefourtheye Oct 15, 2018

Choose a reason for hiding this comment

christian-bromann commented Oct 15, 2018

addaleax commented Oct 15, 2018

christian-bromann commented Oct 15, 2018

refack commented Oct 15, 2018

christian-bromann commented Oct 15, 2018

christian-bromann commented Oct 12, 2018 •

edited

Loading