Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: malloced_unique_ptr & make_malloced_unique #23649

Closed
wants to merge 1 commit into from
Closed

src: malloced_unique_ptr & make_malloced_unique #23649

wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Oct 13, 2018

malloced_unique_ptr is just a specialization of std:unique_ptr using free for deletion, and make_malloced_unique<T> is it's factory using Malloc<T>.

Ref: #23641
Ref: #23543 (review)
Ref: #23434

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1236/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 13, 2018
@refack refack added lib / src Issues and PRs related to general changes in the lib or src directory. blocked PRs that are blocked by other issues or PRs. labels Oct 13, 2018
@refack
Copy link
Contributor Author

refack commented Oct 20, 2018

Dup of #23642

@refack refack closed this Oct 20, 2018
@refack refack deleted the pure-add-malloced-unique-ptr branch October 20, 2018 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refack @nodejs-github-bot