Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win: Fix MSI generation on Visual Studio != 2013 #2365

Merged
merged 2 commits into from
Aug 24, 2015

Commits on Aug 24, 2015

  1. win: fix custom actions on Visual Studio != 2013

    This is a port of nodejs/node-v0.x-archive@16bcd68 .
    
    Original commit message:
    
      The original change that added support for running custom actions
      during the install process
      (nodejs/node-v0.x-archive@e7c84f8) assumed that
      Visual Studio 2013 is used to generate the installer file.
    
      However, that is not always the case, and older versions of Visual
      Studio should allow users to generate Windows installer files. This
      change makes the custom actions visual studio project use the visual
      studio version that is found by vcbuild.bat.
    
      Reviewed-By: João Reis <reis@janeasystems.com>
      PR-URL: nodejs/node-v0.x-archive#25569
    
    PR-URL: nodejs#2365
    Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
    Julien Gilli authored and joaocgreis committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    0acc9b2 View commit details
    Browse the repository at this point in the history
  2. win: fix custom actions for WiX older than 3.9

    This is a port of nodejs/node-v0.x-archive@e192f61 .
    
    Original commit message:
    
      Older WiX versions included a header with extern "C" declaration,
      hence the custom action source must be C++.
    
      Reviewed-By: João Reis <reis@janeasystems.com>
      PR-URL: nodejs/node-v0.x-archive#25569
    
    PR-URL: nodejs#2365
    Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
    joaocgreis committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    bce1aea View commit details
    Browse the repository at this point in the history