Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,lib: move natives and constants to internalBinding() #23663

Closed
wants to merge 1 commit into from
Closed

src,lib: move natives and constants to internalBinding() #23663

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: #22160

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1248/pipeline

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 15, 2018
@addaleax addaleax added the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 15, 2018
@jasnell jasnell mentioned this pull request Oct 15, 2018
Closed
33 tasks
@danbev
Copy link
Contributor

danbev commented Oct 18, 2018

@addaleax Could you rebase this? Thanks

@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/18005/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 20, 2018
@joyeecheung
Copy link
Member

I am not sure if CITGM is in ready shape yet, but I think this needs a CITGM run.

@addaleax
Copy link
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18006/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1594/

@refack
Copy link
Contributor

refack commented Oct 20, 2018

CITGM: ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1594

I don't see anything obviously failing in the CITGM run.

@addaleax
Copy link
Member Author

Landed in 87b808f

@addaleax addaleax closed this Oct 21, 2018
@addaleax addaleax deleted the internalbinding-natives branch October 21, 2018 01:23
addaleax added a commit that referenced this pull request Oct 21, 2018
@addaleax
src,lib: move natives and constants to internalBinding()
87b808f 
Refs: #22160

PR-URL: #23663
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 21, 2018
@addaleax @jasnell
src,lib: move natives and constants to internalBinding()
627f109 
Refs: #22160

PR-URL: #23663
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@starkwang starkwang starkwang approved these changes

@lundibundi lundibundi lundibundi approved these changes

@cjihrig cjihrig cjihrig approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@addaleax @nodejs-github-bot @danbev @joyeecheung @refack @thefourtheye @cjihrig @lundibundi @starkwang @trivikr